Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: fix spurious quotes around :size arg #555

Merged

Conversation

panchoh
Copy link
Contributor

@panchoh panchoh commented Sep 14, 2024

If the size is expressed as a string, Emacs calls bloody murder:

invalid font property (:size . "14.000000")

Refs: 35233f9

If the size is expressed as a string, Emacs calls bloody murder:

    invalid font property (:size . "14.000000")

Refs: 35233f9
@trueNAHO
Copy link
Collaborator

Cc: @jezcope

@jezcope
Copy link
Contributor

jezcope commented Sep 16, 2024

Oh yeah, good catch, I thought I'd tested this but it definitely should not have quotes so not sure how they snuck in!

Copy link
Contributor

@jezcope jezcope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should absolutely have been in my original PR, thanks for catching it!

Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trueNAHO trueNAHO merged commit 149b313 into danth:master Sep 16, 2024
10 checks passed
@panchoh panchoh deleted the fix/emacs-spurious-quotes-around-font-size branch September 16, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants