-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wofi: specify a unit (pt) for font size #552
base: master
Are you sure you want to change the base?
Conversation
IIRC, rofi, tofi, and wofi are pretty much the same and might have the same API. Can you verify whether d31d392 resolves the same issue in those applications? NOTE: I did not test this. |
Also, with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change fixes the issue with wofi (I did not try this commit, I added pt
by hand).
Using the head of https://github.com/jezcope/stylix/tree/fix/wofi-font-size fixes the issue
PS: the referenced commit is not the correct one |
Just tried I haven't used rofi for a while but skimming through its docs it looks like its syntax for styling fonts is slightly different and only needs the number. Example taken from rofi's own theming docs: * {
background-color: Black;
text-color: White;
border-color: White;
font: "Times New Roman 12";
} So AFAICT there was no issue with stylix's configs for tofi and rofi, only for wofi. |
Link: danth#251 Link: danth#552 Reviewed-by: NAHO <[email protected]>
d31d392
to
205c3d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog
v2: 205c3d2
- Do not specify font size unit as pt for
rofi
- Do not specify font size unit as pt for
tofi
- Simplify commit header
Link:
to related issueLink:
to GitHub PR- Add
Reviewed-by: NAHO <[email protected]>
tag
v1: d31d392
- Specify font size unit as pt for
rofi
- Specify font size unit as pt for
tofi
v0: c8d4912
@cgahr, if you want we can add your |
I'm not really sure what you are talking about. What does latexplotlib have to do with that? |
Just adding metadata to the commit that you successfully tested it.
I was referring to the whether the name and email should be the one from the |
Ah I see. Please use |
Should I use the name from the linked PR or just your GitHub account name? |
Github please |
I can also just not include your |
Don't worry! Feel free to include it |
Link: danth#251 Link: danth#552 Tested-by: cgahr <[email protected]> Reviewed-by: NAHO <[email protected]>
205c3d2
to
0525b32
Compare
Without a unit specified in wofi's
style.css
, it emits a warning and defaults to using pixels, which (on my screens anyway) results in the font being larger than intended. This explicitly sets the unit topt
.