Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format.yml: updated uncrustify #7421

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Apr 2, 2025

No description provided.

@firewave firewave force-pushed the uncrustify branch 3 times, most recently from aedd5bc to c93baa8 Compare April 2, 2025 10:18
@firewave
Copy link
Collaborator Author

firewave commented Apr 2, 2025

0.73.0 fails with

Parsing: lib/library.cpp as language CPP
terminate called after throwing an instance of 'std::out_of_range'
  what():  vector::_M_range_check: __n (which is 18446744073709551615) >= this->size() (which is 1)

@firewave
Copy link
Collaborator Author

firewave commented Apr 2, 2025

0.75.0 requires configuration changes

.uncrustify.cfg:421: option 'sp_type_question' is deprecated; did you want to use 'sp_before_ptr_star' instead?
.uncrustify.cfg:915: option 'sp_before_tr_emb_cmt' is deprecated; did you want to use 'sp_before_tr_cmt' instead?
.uncrustify.cfg:918: option 'sp_num_before_tr_emb_cmt' is deprecated; did you want to use 'sp_num_before_tr_cmt' instead?
Option<NUM>: at .uncrustify.cfg:1068: Expected number , for 'indent_shift'; got 'false'
.uncrustify.cfg:1134: option 'indent_sing_line_comments' is deprecated; did you want to use 'indent_single_line_comments_before' instead?
Option<NUM>: at .uncrustify.cfg:1215: Expected number , for 'indent_comma_paren'; got 'false'
Option<NUM>: at .uncrustify.cfg:1219: Expected number , for 'indent_bool_paren'; got 'false'
Option<UNUM>: at .uncrustify.cfg:2757: Expected unsigned number , for 'mod_full_brace_if_chain'; got 'false'
Option<NUM>: at .uncrustify.cfg:2977: Expected number , for 'pp_indent_brace'; got 'true'

@@ -669,7 +669,7 @@ static ValueFlow::Value evaluate(const std::string& op, const ValueFlow::Value&
return result;
}

using BuiltinLibraryFunction = std::function<ValueFlow::Value(const std::vector<ValueFlow::Value>&)>;
using BuiltinLibraryFunction = std::function<ValueFlow::Value (const std::vector<ValueFlow::Value>&)>;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks undesired.

@firewave
Copy link
Collaborator Author

firewave commented Apr 2, 2025

We should probably re-generated the configuration and only include options which are not the default. Currently we include all the options.

@firewave
Copy link
Collaborator Author

firewave commented Apr 8, 2025

We should probably re-generated the configuration and only include options which are not the default. Currently we include all the options.

#7441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant