fixed #12017/#13723 - added command-line option --clang-tidy{=<exe>} and fixed output

[firewave]

No description provided.

[firewave]

Still needs a Python test and requires #7285 and #7291 to be merged.

Prerequisite for fixing https://trac.cppcheck.net/ticket/12053.

[firewave]

Need to make sure it is run within the CI (i.e. clang-tidy is available).

[firewave]

Need to make sure it is run within the CI (i.e. clang-tidy is available).

Confirmed.

test/cli/other_test.py::test_clang_tidy_project 
[gw0] [ 71%] PASSED test/cli/other_test.py::test_clang_tidy_project

[danmar]

if exe ends with ".exe" then don't append ".exe".

[danmar]

but.. I agree with the TODO comment. Use the clangTidyExecutable as-is. Use the exact path provided by the user.

[firewave]

Will extend the tests when I fix the missing invocations.

[danmar]

I think that this code should just use clangTidyExecutable as-is. Remove the whole #ifdef ..

     const std::string exe = mSettings.clangTidyExecutable;

If the user writes --clang-tidy=clang-tidy.exe then you will add the ".exe" that feels bad.

If you really want to append the ".exe" then that should be done in the initialization in settings.h:

    /** Custom clang-tidy executable */
#ifdef _WIN32
    std::string clangTidyExecutable = "clang-tidy.exe";
#else
    std::string clangTidyExecutable = "clang-tidy";
#endif

As you said maybe this is not necessary anyway.

[firewave]

As I said I will address this when the invocation are fixed in a follow-up since it is out-of-scope of the changes here.

The tests for this are also currently missing and I would have to add several overrides because invoking it is partially broken.

[firewave]

Anything still to do here?

[danmar]

alright then.. if you do continue and look at the invocations asap after this then feel free to merge this now..

[firewave]

alright then.. if you do continue and look at the invocations asap after this then feel free to merge this now..

I just had another look and it is unfortunately not straight forward to fix.

But on the upside it should automatically fix itself when FileWithDetails and FileSettings have finally been merged. But that requires the language and the define (which will also involve simplecpp changes) handling to be fixed first. So it will probably be a while given the scope and there are still more pressing core issues.