feat(web): generate titles for clusters #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying unsight with
|
| Latest commit: |
e12c486
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3840fe27.unsight.pages.dev |
| Branch Preview URL: | https://feat-cluster-titles.unsight.pages.dev |
Kai-ros
approved these changes
Mar 15, 2025
There was a problem hiding this comment.
@danielroe Was too slow! Sharing anyways in case you care for the feedback. 😆
| @@ -136,7 +136,7 @@ function preprocessText(text: string): string { | |||
| .trim() | |||
| } | |||
|
|
|||
| function chunkIssue(issue: Issue | RestIssue, exclude?: Set<string>) { | |||
| export function chunkIssue(issue: Pick<Issue | RestIssue, 'labels' | 'title' | 'body'>, exclude?: Set<string>) { | |||
There was a problem hiding this comment.
NIT: Fairly opposed to string literals as of TS5.8, would suggest instead opting for a mapped type w/as const. The trade-off of less flexibility and a little more TS syntactical complexity here is worthwhile when gaining the stronger type safety and type inference when using an indexed access type. And I'd add that personally I find Pick more readable with just types in it and no strings.
Suggested change
| export function chunkIssue(issue: Pick<Issue | RestIssue, 'labels' | 'title' | 'body'>, exclude?: Set<string>) { | |
| export const issueSegments = { labels: 'labels', title: 'title', body: 'body', } as const; | |
| export type IssueSegments = (typeof issueSegments)[keyof typeof issueSegments]; | |
| export function chunkIssue( issue: Pick<Issue | RestIssue, IssueSegments>, exclude?: Set<string>, ) { const labels = getLabels(issue).filter((l) => !exclude?.has(l)); return preprocessText( ${issue[issueSegments.title]}\n${labels.join(', ')}\n${ issue[issueSegments.body] }, ); } |
| @@ -152,6 +152,6 @@ async function generateEmbedding(text: string): Promise<number[]> { | |||
| } | |||
| } | |||
|
|
|||
| function getLabels(issue: Issue | RestIssue) { | |||
| function getLabels(issue: Pick<Issue | RestIssue, 'labels' | 'title' | 'body'>) { | |||
There was a problem hiding this comment.
NIT: And you get to re-use it down here:
Suggested change
| function getLabels(issue: Pick<Issue | RestIssue, 'labels' | 'title' | 'body'>) { | |
| function getLabels(issue: Pick<Issue | RestIssue, IssueSegments >) { |
|
good points! feel free to open a pr if you want 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5