Skip to content

Commit

Permalink
[SYCL][InvokeSimd] Fix two XFAIL tests (#14906)
Browse files Browse the repository at this point in the history
For reference_argument.cpp, the test `RUN` line was wrong, and I added
the real error message to the `CHECK` string.

For `simd32_platform_error.cpp`, all Intel GPUs we test on report as
support SIMD32 (for the ones that don't in hardware, it is probably
emulated but it definitely works), so they don't throw this error so we
can't test it, so just remove the test.

Closes: intel/llvm#14643
Closes: intel/llvm#14644

Signed-off-by: Sarnie, Nick <[email protected]>
  • Loading branch information
sarnex authored Aug 5, 2024
1 parent 1edc943 commit 7d3ac99
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 35 deletions.
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
// RUN: not %{build} -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr %s -o %t.out 2>&1 | FileCheck
// RUN: not %{build} -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr %s -o %t.out 2>&1 | FileCheck %s
//
// TODO FIXME: Currently compile fail with "no or multiple invoke_simd targets
// found"
// XFAIL: gpu
/*
* Test case specification: Test and report errors if reference argument is
* passed to invoked ESIMD function
Expand Down Expand Up @@ -79,7 +76,7 @@ int main(void) {

float res = invoke_simd(sg, SIMD_CALLEE<int_ref>, uniform{A},
B[wi_id], uniform{i});
// CHECK: TODO FIXME
// CHECK: invoke_simd does not support callables with reference arguments
C[wi_id] = res;
});
});
Expand Down
30 changes: 0 additions & 30 deletions sycl/test-e2e/InvokeSimd/Spec/simd_size/simd32_platform_error.cpp

This file was deleted.

0 comments on commit 7d3ac99

Please sign in to comment.