Merge pull request #1430 from mgol/module-github-override-fix

Fix the shouldUseGitHubOverride logic for ESM imports
danger · Apr 16, 2024 · 09cf908 · 09cf908
2 parents 8371557 + de05921
commit 09cf908
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/source/platforms/github/_tests/_customGitHubRequire.test.ts b/source/platforms/github/_tests/_customGitHubRequire.test.ts
@@ -31,6 +31,12 @@ describe("shouldUseGitHubOverride", () => {
     const parent: any = { filename: dangerPrefix + "./my-import" }
     expect(shouldUseGitHubOverride(module, parent)).toBeTruthy()
   })
+
+  it("ignores modules without a parent", () => {
+    const module = "./peril"
+    const parent: any = undefined
+    expect(shouldUseGitHubOverride(module, parent)).toBeFalsy()
+  })
 })
 
 describe("customGitHubResolveRequest", () => {

diff --git a/source/platforms/github/customGitHubRequire.ts b/source/platforms/github/customGitHubRequire.ts
@@ -86,9 +86,9 @@ export async function getGitHubFileContents(
 
 // Setup a callback used to determine whether a specific `require` invocation
 // needs to be overridden.
-export const shouldUseGitHubOverride = (request: string, parent: NodeModule): boolean => {
+export const shouldUseGitHubOverride = (request: string, parent?: NodeModule): boolean => {
   // Is it a from a file we're handling, and is it relative?
-  if (parent.filename.startsWith(dangerPrefix) && request.startsWith(".")) {
+  if (parent?.filename.startsWith(dangerPrefix) && request.startsWith(".")) {
     return true
   }
   // Basically any import that's not a relative import from a Dangerfile