Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add hash to rsf{n} #1203

Merged
merged 3 commits into from
Feb 1, 2025
Merged

fix(core): add hash to rsf{n} #1203

merged 3 commits into from
Feb 1, 2025

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Jan 30, 2025

close #1202

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jan 31, 2025 0:36am

Copy link

codesandbox-ci bot commented Jan 30, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi marked this pull request as ready for review January 31, 2025 00:24
@knpwrs
Copy link

knpwrs commented Jan 31, 2025

Stale clients will still have failed requests. Can we have some sort of event on the frontend to recover from that?

@dai-shi
Copy link
Owner Author

dai-shi commented Jan 31, 2025

Stale clients will still have failed requests. Can we have some sort of event on the frontend to recover from that?

The issue is not only with rsf but with rsc too.
I think it's for #1037 which is still under discussion. I have a vague idea, but not concrete yet.

@dai-shi dai-shi merged commit 117dd0f into main Feb 1, 2025
26 checks passed
@dai-shi dai-shi deleted the add-rsf-hash branch February 1, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there any way to guarantee rsf{n} endpoints are stable across builds?
2 participants