[compute logs] fix truncation prefix message in ui #28111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangenfeld
commented
Feb 27, 2025
| @@ -94,7 +94,7 @@ export const RawLogContent = React.memo((props: Props) => { | |||
| <RelativeContainer> | |||
| <LogContent | |||
| isSelected={true} | |||
| content={logData} | |||
| content={content} | |||
There was a problem hiding this comment.
content was defined above but then not used - i assume on accident
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 5d1a02e. |
gibsondan
approved these changes
Feb 27, 2025
alangenfeld
deleted the
al/02-27-_compute_logs_fix_truncation_prefix_message_in_ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How I Tested These Changes