[components] Add *Component suffix to all component classes #28082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
smackesey
force-pushed
the
sean/components/add-component-suffix
branch
from
7978ba3 to
c445c9e
Compare
smackesey
force-pushed
the
sean/components/rm-registered-component-type
branch
from
0795bc7 to
5f7dca2
Compare
smackesey
force-pushed
the
sean/components/add-component-suffix
branch
from
c445c9e to
daf1923
Compare
smackesey
force-pushed
the
sean/components/rm-registered-component-type
branch
from
5f7dca2 to
25abe4f
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 980534c. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-mq1cxbnid-elementl.vercel.app Direct link to changed pages: |
schrockn
approved these changes
Feb 27, 2025
Base automatically changed from
sean/components/rm-registered-component-type
to
master
February 27, 2025 15:50
[INTERNAL_BRANCH=sean/components/add-component-suffix]
smackesey
force-pushed
the
sean/components/add-component-suffix
branch
from
daf1923 to
980534c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal companion PR: https://github.com/dagster-io/internal/pull/14031
Summary & Motivation
Add a
*Componentsuffix to all of our component classes, and add a test to make sure this is maintained.How I Tested These Changes
Existing test suite.