Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Alerts: Add shared components for Jobs #27982

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Feb 21, 2025

Summary & Motivation

Corresponds to https://github.com/dagster-io/internal/pull/13886.

Add shared components for rendering Alert details in the Jobs sidebar. This is effectively a no-op in OSS.

How I Tested These Changes

TS, lint, jest.

See test plan on internal PR.

Copy link
Member Author

Copy link

github-actions bot commented Feb 21, 2025

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-4hykn1ovx-elementl.vercel.app
https://dish-alerts-shared-jobs.core-storybook.dagster-docs.io

Built with commit 4864497.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@anuthebananu anuthebananu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member Author

hellendag commented Feb 21, 2025

Merge activity

  • Feb 21, 11:40 AM CST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 21, 11:41 AM CST: Graphite rebased this pull request as part of a merge.
  • Feb 21, 11:42 AM CST: A user merged this pull request with Graphite.

[INTERNAL_BRANCH=dish/oper-1642-alerts-job-detail-view]
@hellendag hellendag force-pushed the dish/alerts-shared-jobs branch from a03ad8d to 4864497 Compare February 21, 2025 17:41
@hellendag hellendag merged commit a1222f0 into master Feb 21, 2025
5 of 6 checks passed
@hellendag hellendag deleted the dish/alerts-shared-jobs branch February 21, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants