Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Cloudflare R2 kinds tag #27911

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Adds Cloudflare R2 kinds tag #27911

merged 1 commit into from
Feb 19, 2025

Conversation

cmpadden
Copy link
Contributor

Summary & Motivation

Resolves #27882.

How I Tested These Changes

Built UI locally and ran example snippet:

import dagster as dg


@dg.asset(kinds={"r2"})
def asset():
    pass


defs = dg.Definitions(assets=[asset])
image

Changelog

  • [ui] adds kinds tag for Cloudflare R2

@cmpadden cmpadden mentioned this pull request Feb 19, 2025
@cmpadden cmpadden requested review from braunjj and salazarm February 19, 2025 15:07
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-6i4mqwijf-elementl.vercel.app
https://colton-add-r2-kinds-tag.core-storybook.dagster-docs.io

Built with commit 9437707.
This pull request is being automatically deployed with vercel-action

@salazarm
Copy link
Contributor

Don't we also add these to the docs site?

@cmpadden
Copy link
Contributor Author

cmpadden commented Feb 19, 2025

Don't we also add these to the docs site?

That's a good call out. Just updated a script to do it programmatically!

https://github.com/dagster-io/dagster/pull/27912/files

I plan to add it to our build process soon, but for now it's a manual yarn rebuild-kinds-tags.

@cmpadden cmpadden merged commit b818758 into master Feb 19, 2025
7 checks passed
@cmpadden cmpadden deleted the colton/add-r2-kinds-tag branch February 19, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add r2 asset kind
2 participants