[3/3][Selection syntax] Remove name_substring + support wildcard filtering #27726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salazarm
requested review from
bengotow,
hellendag,
benpankow and
OwenKephart
salazarm
changed the base branch from
master
to
salazarm/remove-key-substring-frontend
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 06b3830. |
salazarm
requested review from
clairelin135
and removed request for
OwenKephart
hellendag
approved these changes
Feb 11, 2025
| const selection = [...this.all_ops].filter((i) => i.name.includes(value)); | ||
| const value: string = getValue(ctx.keyValue()); | ||
| const regex: RegExp = new RegExp(`^${escapeRegExp(value).replaceAll('\\*', '.*')}$`); | ||
| const selection = [...this.all_ops].filter((i) => regex.test(i.name)); |
Base automatically changed from
salazarm/remove-key-substring-frontend
to
master
February 18, 2025 20:18
salazarm
force-pushed
the
salazarm/remove-name-substring-frontend
branch
from
3f32437 to
06b3830
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Follow up to:
#27724
and
#27720
We want to remove the special
name_substringfilter and instead allow for wildcard matching, eg:name:*example*.How I Tested These Changes
jest