Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-591 Switch embedded example code to CodeExample component #27605

Merged
merged 9 commits into from
Feb 6, 2025

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Feb 6, 2025

Summary & Motivation

See title -- need to do this before re-implementing versioned docs.

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

@neverett neverett added the area: docs Related to documentation in general label Feb 6, 2025
@neverett neverett self-assigned this Feb 6, 2025
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
@neverett neverett marked this pull request as ready for review February 6, 2025 18:28
@neverett neverett requested a review from cmpadden February 6, 2025 18:28
Copy link

github-actions bot commented Feb 6, 2025

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-djgj7jhhs-elementl.vercel.app

Direct link to changed pages:

Copy link
Contributor

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whew!

@neverett neverett merged commit 9348382 into master Feb 6, 2025
7 of 8 checks passed
@neverett neverett deleted the nikki/docs/switch-to-codeexample branch February 6, 2025 18:50
LoHertel pushed a commit to LoHertel/dagster that referenced this pull request Feb 11, 2025
…r-io#27605)

## Summary & Motivation

See title -- need to do this before re-implementing versioned docs.

## How I Tested These Changes

## Changelog

> Insert changelog entry or delete this section.

---------

Signed-off-by: nikki everett <[email protected]>
braunjj pushed a commit that referenced this pull request Feb 14, 2025
## Summary & Motivation

See title -- need to do this before re-implementing versioned docs.

## How I Tested These Changes

## Changelog

> Insert changelog entry or delete this section.

---------

Signed-off-by: nikki everett <[email protected]>
brentjericho pushed a commit to brentjericho/dagster that referenced this pull request Feb 21, 2025
…r-io#27605)

## Summary & Motivation

See title -- need to do this before re-implementing versioned docs.

## How I Tested These Changes

## Changelog

> Insert changelog entry or delete this section.

---------

Signed-off-by: nikki everett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants