Update text styles #27318
Merged
Update text styles #27318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 69f8ca9. |
|
thank you for doing this |
salazarm
added a commit
that referenced
this pull request
Jan 29, 2025
## Summary & Motivation Adds new text styles from #21450 which was reverted in #21517. I'm adding the new styles, and updating a couple of the existing ones (Title and Heading are the main changes, they're bigger now). Assuming this is fine since we did this in the original PR. ## How I Tested These Changes briefly went around the app and everything looked fine. The only concrete changes are going to be title/headline are bigger now which seems like the intention in the original PR: <img width="281" alt="Screenshot 2025-01-23 at 1 14 38 PM" src="https://github.com/user-attachments/assets/e039f856-a26d-45d1-91a1-bf0a10998199" /> <img width="366" alt="Screenshot 2025-01-23 at 1 14 29 PM" src="https://github.com/user-attachments/assets/d3374088-7756-4098-afa2-6e78549c4b96" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adds new text styles from #21450 which was reverted in #21517.
I'm adding the new styles, and updating a couple of the existing ones (Title and Heading are the main changes, they're bigger now). Assuming this is fine since we did this in the original PR.
How I Tested These Changes
briefly went around the app and everything looked fine. The only concrete changes are going to be title/headline are bigger now which seems like the intention in the original PR: