[9/n][dagster-fivetran] Implement sync and poll methods in FivetranClient #25911
+298
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2024
Merged
[5/n][dagster-fivetran] Implement
FivetranWorkspaceData to FivetranConnectorTableProps method
#25797
Merged
This was referenced Nov 13, 2024
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+618
to
+634
| def update_schedule_type( | ||
| self, connector_id: str, schedule_type: Optional[str] = None | ||
| ) -> Mapping[str, Any]: | ||
| """Updates the schedule type property of the connector to either "auto" or "manual". | ||
| Args: | ||
| connector_id (str): The Fivetran Connector ID. You can retrieve this value from the | ||
| "Setup" tab of a given connector in the Fivetran UI. | ||
| schedule_type (Optional[str]): Either "auto" (to turn the schedule on) or "manual" (to | ||
| turn it off). | ||
| Returns: | ||
| Dict[str, Any]: Parsed json data representing the API response. | ||
| """ | ||
| if schedule_type not in ["auto", "manual"]: | ||
| check.failed(f"schedule_type must be either 'auto' or 'manual': got '{schedule_type}'") | ||
| return self.update_connector(connector_id, properties={"schedule_type": schedule_type}) |
There was a problem hiding this comment.
The schedule_type parameter is marked as Optional[str] but the validation logic will raise an error if None is passed. Consider either removing the Optional type hint or adding a None check before the schedule_type validation to align the type hints with the actual behavior.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog