[ui] Fix base path when opening a new window #25909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hellendag
commented
Nov 13, 2024
| @@ -111,12 +113,12 @@ function OpenInLaunchpadButton({ | |||
| })), | |||
| }), | |||
| ); | |||
| window.open( | |||
There was a problem hiding this comment.
We may also want to consider linting against this.
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 9713613. |
salazarm
approved these changes
Nov 14, 2024
gibsondan
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary & Motivation Preserve the base path when opening a new tab for "Open in Launchpad" on a schedule/sensor dry run. I created a hook to wrap extraction of the base path and using `_blank` as the target. I see a few places where we're using `window.open` without applying the base path, so in a followup I'll go through and clean those up too. ## How I Tested These Changes Open a schedule, click "Test schedule", choose a tick. Click "Open in Launchpad", verify that the new tab opens with a URL that includes the base path (deployment) prefix. ## Changelog [ui] Fix "Open in Playground" link when testing a schedule or sensor by ensuring that it opens to the correct deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Preserve the base path when opening a new tab for "Open in Launchpad" on a schedule/sensor dry run.
I created a hook to wrap extraction of the base path and using
_blankas the target. I see a few places where we're usingwindow.openwithout applying the base path, so in a followup I'll go through and clean those up too.How I Tested These Changes
Open a schedule, click "Test schedule", choose a tick. Click "Open in Launchpad", verify that the new tab opens with a URL that includes the base path (deployment) prefix.
Changelog
[ui] Fix "Open in Playground" link when testing a schedule or sensor by ensuring that it opens to the correct deployment.