Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] New Evaluations list table #25908

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Nov 13, 2024

Summary & Motivation

Create an evaluation list table view based on design.

Clicking the timestamp opens a dialog with the evaluations. Clicking the "X runs" link will open the runs table.

Just a Storybook example for now.

Screenshot 2024-11-13 at 14 32 55 Screenshot 2024-11-13 at 14 33 02

How I Tested These Changes

Storybook.

Copy link
Member Author

hellendag commented Nov 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hellendag hellendag marked this pull request as ready for review November 13, 2024 20:34
@hellendag hellendag force-pushed the dish/fe-677-create-new-evaluation-table branch from 652b172 to ab4f68f Compare November 13, 2024 20:35
Copy link

github-actions bot commented Nov 13, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-pmllrzayc-elementl.vercel.app
https://dish-fe-677-create-new-evaluation-table.core-storybook.dagster-docs.io

Built with commit ab4f68f.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we virtualize the table?

Copy link
Member Author

It'll be paginated at I think 25 per page, so I think we won't need to (yet).

Copy link
Member Author

hellendag commented Nov 14, 2024

Merge activity

  • Nov 14, 3:42 PM CST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 14, 3:43 PM CST: A user merged this pull request with Graphite.

@hellendag hellendag merged commit 1bab169 into master Nov 14, 2024
1 of 2 checks passed
@hellendag hellendag deleted the dish/fe-677-create-new-evaluation-table branch November 14, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants