-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8/n][dagster-fivetran] Implement FivetranConnector and FivetranDestination #25889
Open
maximearmstrong
wants to merge
16
commits into
master
Choose a base branch
from
maxime/rework-fivetran-8
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+179
−109
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c8f3fa2
[5/n][dagster-tableau] Implement FivetranWorkspaceData to FivetranCon…
maximearmstrong 0ba6115
Cache to_fivetran_connector_table_props_data
maximearmstrong d3153ad
Add get_fivetran_connector_table_name to utils
maximearmstrong 8f009e2
Move api_key and api_secret mocks to conftest
maximearmstrong d35d3d9
Lint
maximearmstrong cea52d9
[8/n][dagster-fivetran] Implement FivetranConnector and FivetranDesti…
maximearmstrong f914e99
Fix merge
maximearmstrong 6cc879f
Add builder fn
maximearmstrong 3d4f1c9
Update FivetranDestination
maximearmstrong df94068
Update FivetranConnector
maximearmstrong ee9350b
Revert legacy tests, make FivetranTable.columns optional
maximearmstrong d63c02b
Remove todo
maximearmstrong c436c46
move connector status logic to FivetranConnector
maximearmstrong 854e3a0
Decouple schema config from connector, implement connector properties
maximearmstrong ba28c05
Update connector setup state property
maximearmstrong 283f3d8
Store setup state as string
maximearmstrong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[1]
FivetranConnectorTableProps
was updated to take aFivetranSchemaConfig
object instead of aMapping[str, Any]
one. The goal here is to keepFivetranConnectorTableProps
as close as possible to the new implementation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the two implementations are built across the same version of fivetran's API, it makes sense to me that we should be able to share implementation across these subclasses.