-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4/n] [RFC] add launch multiple runs backend functionality #25880
base: dliu27/add-manual-tick-to-automation-rows
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ | |
|
||
from dagster_graphql.implementation.fetch_runs import get_run_ids, get_runs, get_runs_count | ||
from dagster_graphql.implementation.utils import UserFacingGraphQLError | ||
from dagster_graphql.schema.backfill import pipeline_execution_error_types | ||
from dagster_graphql.schema.errors import ( | ||
GrapheneInvalidPipelineRunsFilterError, | ||
GraphenePythonError, | ||
|
@@ -73,17 +74,22 @@ class Meta: | |
|
||
class GrapheneLaunchRunResult(graphene.Union): | ||
class Meta: | ||
from dagster_graphql.schema.backfill import pipeline_execution_error_types | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why was this removed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and why was it there in the first place 🤔 |
||
|
||
types = launch_pipeline_run_result_types + pipeline_execution_error_types | ||
|
||
name = "LaunchRunResult" | ||
|
||
|
||
class GrapheneLaunchRunReexecutionResult(graphene.Union): | ||
class GrapheneLaunchMultipleRunsResult(graphene.ObjectType): | ||
"""Contains results from multiple pipeline launches.""" | ||
|
||
launchMultipleRunsResult = non_null_list(GrapheneLaunchRunResult) | ||
|
||
class Meta: | ||
from dagster_graphql.schema.backfill import pipeline_execution_error_types | ||
name = "LaunchMultipleRunsResult" | ||
|
||
|
||
class GrapheneLaunchRunReexecutionResult(graphene.Union): | ||
class Meta: | ||
types = launch_pipeline_run_result_types + pipeline_execution_error_types | ||
|
||
name = "LaunchRunReexecutionResult" | ||
|
@@ -213,6 +219,7 @@ def parse_run_config_input( | |
|
||
types = [ | ||
GrapheneLaunchRunResult, | ||
GrapheneLaunchMultipleRunsResult, | ||
GrapheneLaunchRunReexecutionResult, | ||
GrapheneLaunchPipelineRunSuccess, | ||
GrapheneLaunchRunSuccess, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This permission check here can make the whole mutation fail, and in this case the output would be a single GrapheneUnauthorizedError so I believe your output should be a union of
GrapheneLaunchMultipleRunsResult
andGrapheneUnauthorizedError
and alsoGraphenePythonError
since we're using@capture_error
.