Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env vars first #34

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/serverless_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
push:
branches:
- "main"
- "env-vars-first"
env:
DAGSTER_CLOUD_URL: ${{ secrets.DAGSTER_CLOUD_SERVERLESS_URL }}
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_SERVERLESS_API_TOKEN }}
Expand Down
8 changes: 8 additions & 0 deletions actions/serverless_prod_deploy/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@ runs:
env_vars: ${{ inputs.env_vars }}
base_image: ${{ inputs.base_image }}

- name: Print out env var inputs
run: echo "${{ inputs.env_vars }}"
shell: bash

- name: Print out Dockerfile
run: cat ${{ fromJson(inputs.location).directory }}/Dockerfile
shell: bash

- name: Build and push Docker image
uses: docker/build-push-action@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion actions/utils/copy_template/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ inputs:
description: "A string of the base image name for the deployed code location image."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.6"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:env-vars-first"
entrypoint: "/copy_template.sh"
2 changes: 1 addition & 1 deletion actions/utils/deploy/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ outputs:
description: "The Cloud deployment associated with this branch."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.6"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:env-vars-first"
entrypoint: "/deploy.sh"
args:
- ${{ inputs.pr }}
2 changes: 1 addition & 1 deletion actions/utils/notify/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ inputs:

runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.6"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:env-vars-first"
entrypoint: "/notify.sh"
args:
- ${{ inputs.pr }}
2 changes: 1 addition & 1 deletion actions/utils/registry_info/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ inputs:
description: "Alternative to providing organization ID. The URL of your Dagster Cloud organization."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.6"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:env-vars-first"
entrypoint: "/registry_info.sh"
2 changes: 1 addition & 1 deletion actions/utils/run/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ outputs:
description: "The ID of the launched run."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.6"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:env-vars-first"
entrypoint: "/run.sh"
args:
- ${{ inputs.pr }}
2 changes: 1 addition & 1 deletion src/copy_template.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ else
fi


cat /Dockerfile.template >> ${INPUT_TARGET_DIRECTORY}/Dockerfile
cat $(python /expand_env_vars.py) >> ${INPUT_TARGET_DIRECTORY}/Dockerfile
cat /Dockerfile.template >> ${INPUT_TARGET_DIRECTORY}/Dockerfile