Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CE-528] add CI for quality checks: ruff and pytest #12

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

cmpadden
Copy link
Collaborator

@cmpadden cmpadden commented Oct 22, 2024

Adds quality checks (ruff and pytest) in CI.

  • Creates a template GitHub action template-quality-check.yml
  • Creates an action check-dagster-modal.yml that implements the template

Merging is blocked if a check does not pass.

Validates that successful and failure paths work as expected.
image

@cmpadden cmpadden changed the title [dagster-modal] intentional test failure for CI validation [all] add CI for quality checks: ruff and pytest Oct 22, 2024
@cmpadden cmpadden changed the title [all] add CI for quality checks: ruff and pytest [CE-528] add CI for quality checks: ruff and pytest Oct 22, 2024
@cmpadden cmpadden merged commit 5640dba into main Oct 23, 2024
1 check passed
@cmpadden cmpadden deleted the colton/intentional-test-failure branch October 23, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant