Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor text changes #159

Merged
merged 13 commits into from
Jun 19, 2024
Merged

Minor text changes #159

merged 13 commits into from
Jun 19, 2024

Conversation

cyrraz
Copy link
Owner

@cyrraz cyrraz commented Jun 15, 2024

A set of textual changes to improve the example gallery.

@0ctagon
Copy link
Collaborator

0ctagon commented Jun 17, 2024

Copy link
Collaborator

@0ctagon 0ctagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR.
Please check the few not that important comments before merging.

pyproject.toml Outdated
@@ -24,7 +24,7 @@ requires-python = ">=3.7"
dependencies = [
"boost-histogram~=1.4.0",
"numpy>=1.14.5",
"matplotlib>=3.0",
"matplotlib<=3.8.1",
Copy link
Collaborator

@0ctagon 0ctagon Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding


      run: |
        python -m pip install --upgrade pip
        python -m pip install matplotlib==3.8.1   <-------------
        python -m pip install flit pytest pre-commit
        flit install

in python-package.yaml instead

@0ctagon 0ctagon merged commit d0e6ee6 into main Jun 19, 2024
5 checks passed
@0ctagon 0ctagon deleted the minor-text-changes branch June 19, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants