Add plot_only option in plot_data_model_comparison #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could do a minor release after #154 and this PR are merged |
cyrraz
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only getting the main or comparison ax from
plot_data_model_comparison()is not that trivial. Copying/moving axes to other figures is impossible to do in matplotlib. To redo the axes, the user could redo the plot by callingplot_model()andplot_error_hist(), or copy/pasting what we do for functions for the comparison ax, but this solution is complicated and the plot is already here inplot_data_model_comparison(). The user could usefig.delaxes(), but he needs to put the ticks and label back forax_main, and thefigzisewill still be the 2 axes one, resizing theax_comparisonto a standard size is messy.`This proposition is a small quality of life improvement to give the user the possibility to only keep one of the two axes on the fig, and remove the other, that works cleanly.