chore: make mobx decoratorless #31459
Merged
+360
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/update_mobx_decoratorless
|
| Run status |
|
| Run duration | 15m 41s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
133
|
Skipped
|
0
|
Passing
|
5559
|
| View all changes introduced in this branch ↗︎ | |
|
will merge in after the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
As we attempt to move to
tsxinternally to interpret typescript files, one thing that is difficult is supporting experimentalDecorators as the specification has changed and is the de facto implementation in TypeScript 5. In other words, experimentalDecorators`uses stage 2 decorators when the default implementation is now stage 3. The mobx migration guide mentions to remove experimentalDecorators when performing the migration off of decorators, but it also suggests that stage 3 decorators are supported in the enabling decorators guide. To reduce confusion, it's probably best to not use decorators and use the standard implementation as decorators are now opt-in.Steps to test
Verify the reporter works exactly the same and observable updates are performed as expected
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?