fix: remove 'new' badge from Create from Component, fix parsing #31457
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astone123
commented
Apr 7, 2025
| @@ -33,6 +33,7 @@ export class CodegenActions { | |||
| let result = parseReactComponent(src, { | |||
| resolver: findAllWithLink(exportResolver, reactDocgenResolvers), | |||
| babelOptions: { | |||
| configFile: false, | |||
There was a problem hiding this comment.
This option disables the use of a config file for Babel. this is what we want since we're calling it directly, we don't want to pick up any config file that might be in the project
There was a problem hiding this comment.
is it possible to add a test for this?
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
create-from-component-fix
|
| Run status |
|
| Run duration | 10m 06s |
| Commit |
|
| Committer | astone123 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
260
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
44.19%
|
|
|---|---|
|
Untested elements
|
72
|
|
Tested elements
|
57
|
Accessibility
94.9%
|
|
|---|---|
|
Failed rules
|
0 critical
6 serious
0 moderate
1 minor
|
|
Failed elements
|
129
|
AtofStryker
requested changes
Apr 7, 2025
| @@ -33,6 +33,7 @@ export class CodegenActions { | |||
| let result = parseReactComponent(src, { | |||
| resolver: findAllWithLink(exportResolver, reactDocgenResolvers), | |||
| babelOptions: { | |||
| configFile: false, | |||
There was a problem hiding this comment.
is it possible to add a test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR removes the "New" badge for the Create from Component feature - we released it over two years ago. It also fixes an issue where we would fail to parse component files for certain projects that had babel configurations in their project root. You can see this issue with
cypress-servicesdashboard tests - if you try to use Create from Component with any of these files, it will error on all of them because of Babel plugin issues from the project's Babel config. We don't want to use the project's configuration file.Steps to test
On develop
cypress-services/frontend/packages/dashboardin CTPR Tasks
cypress-documentation?type definitions?