-
Notifications
You must be signed in to change notification settings - Fork 3.3k
breaking: remove Angular 17 support #31446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/15.0.0
Are you sure you want to change the base?
Conversation
e1def53
to
dce2f6e
Compare
BREAKING CHANGE: Removed support for Angular 17. Only Angular 18 and 19 are now supported. This change affects the @cypress/angular package. Addresses #31303.
cca72cd
to
aa36f04
Compare
aa36f04
to
93b6ba4
Compare
@@ -6,7 +6,7 @@ Mount Angular components in the open source [Cypress.io](https://www.cypress.io/ | |||
|
|||
## Requirements | |||
|
|||
- Angular 17.2.0+ (Cypress 13 and under supports Angular 13 - 16) | |||
- Angular 18.0.0+ (Cypress 13 and under supports Angular 13 - 16) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AtofStryker This note is now a bit weird with it mentioning no way to run Angular 17
@@ -31,7 +31,7 @@ | |||
|
|||
## Requirements | |||
|
|||
- Angular 17.2.0+ (Cypress 13 and under supports Angular 13 - 16) | |||
- Angular 18.0.0+ (Cypress 13 and under supports Angular 13 - 16) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too
@jennifer-shehane this really should be a WIP but I was trying to figure out how to kick off CI with cursor. As it stands the cursor agent wrote this whole PR 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 16 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (5)
- npm/angular/package.json: Language not supported
- npm/cypress-schematic/package.json: Language not supported
- system-tests/projects/angular-17/angular.json: Language not supported
- system-tests/projects/angular-17/package.json: Language not supported
- system-tests/projects/angular-signals/package.json: Language not supported
Comments suppressed due to low confidence (1)
system-tests/projects/angular-signals/src/signals-complex/signals-complex.component.ts:29
- The updated comment is now ambiguous regarding the affected Angular version. Since Angular 17 is no longer supported, consider clarifying the comment to indicate whether this bug pertains to older Angular versions or removing the version-specific note altogether.
// there is a bug in Angular that doesn't rerender the signal when set outside the component context
Description
This PR removes support for Angular 17 as part of our ongoing maintenance and support strategy. This is a breaking change that affects users of the
@cypress/angular
package.Changes
Breaking Changes
@cypress/angular
package no longer supports Angular 17Migration Steps
Users currently using Angular 17 with Cypress should:
Related Issues
Testing
Additional Notes