Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock server: catch errors in graphql execution #2073

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

MetRonnie
Copy link
Member

E.g. doing this named query without the $id arg:

query LogFiles {
  logFiles (id: "foo") {
    files
  }
}

would crash the nodemon server. Now it returns the proper error

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests, changelog, docs not needed

@MetRonnie MetRonnie self-assigned this Feb 20, 2025
@markgrahamdawson markgrahamdawson merged commit b61fb77 into cylc:master Feb 20, 2025
7 checks passed
@MetRonnie MetRonnie deleted the mock-server branch February 20, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants