Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoophpCollectionFactory. #344

Merged
merged 8 commits into from
Jun 17, 2022
Merged

Add LoophpCollectionFactory. #344

merged 8 commits into from
Jun 17, 2022

Conversation

drupol
Copy link
Contributor

@drupol drupol commented May 30, 2022

Hi,

Here's my first attempt at adding loophp/collection in cycle/orm.

@butschster
Copy link
Contributor

Hi, you need to put loop package into composer

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #344 (93f802e) into 2.x (d097d17) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##                2.x     #344      +/-   ##
============================================
- Coverage     91.56%   91.55%   -0.02%     
- Complexity     1726     1733       +7     
============================================
  Files           111      112       +1     
  Lines          4173     4202      +29     
============================================
+ Hits           3821     3847      +26     
- Misses          352      355       +3     
Impacted Files Coverage Δ
src/Collection/LoophpCollectionFactory.php 83.33% <83.33%> (ø)
src/Relation/ManyToMany.php 95.58% <0.00%> (-0.44%) ⬇️
src/Transaction/UnitOfWork.php 95.21% <0.00%> (+0.02%) ⬆️
src/Factory.php 96.36% <0.00%> (+0.13%) ⬆️
src/Config/RelationConfig.php 89.47% <0.00%> (+9.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d097d17...93f802e. Read the comment docs.

@roxblnfk roxblnfk added this to the 2.2.x milestone May 31, 2022
@roxblnfk
Copy link
Member

By the way the documentation should be updated
https://github.com/cycle/docs/blob/2.x/docs/en/relation/collections.md

@roxblnfk roxblnfk added the status:ready for merge The pull request is OK to be merged. label Jun 17, 2022
@drupol drupol marked this pull request as ready for review June 17, 2022 21:24
@roxblnfk roxblnfk merged commit 40bb658 into cycle:2.x Jun 17, 2022
@drupol drupol deleted the feat/add-loophp-collection branch June 17, 2022 23:21
@drupol
Copy link
Contributor Author

drupol commented Jun 17, 2022

Extremelly cool, thanks !

@butschster
Copy link
Contributor

Extremelly cool, thanks !

Thank you, for contribution!

@roxblnfk
Copy link
Member

roxblnfk commented Jul 5, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for merge The pull request is OK to be merged.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants