Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use map[string]string instead of []string internally #188

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

mcanevet
Copy link
Contributor

@mcanevet mcanevet commented Jan 7, 2021

What does this PR do?

This PR uses a map[string]string instead of a []string in ̀action.go` so that we have a more flexible structure to output the secrets in different ways (see #184).
For example we could easily have:

  • quote multi-line secrets in @SUMMONENVFILE (if we find an agreement on this)
  • have @SUMMONJSONFILE or @SUMMONYAMLFILE magic strings like @SUMMONENVFILE

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@mcanevet mcanevet requested a review from a team as a code owner January 7, 2021 08:10
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcanevet,
Thank you for this contribution! This makes a lot of sense, keeping keys and values separate until they absolutely have to be combined. This will probably makes things a little more extensible for adding enhancements/features to Summons actions.

@diverdane diverdane merged commit 5a73e4a into cyberark:master Jan 7, 2021
@mcanevet mcanevet deleted the map_string_string branch January 7, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants