Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not keep deleted annotations in ram #9256

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Eldies
Copy link
Contributor

@Eldies Eldies commented Mar 25, 2025

Motivation and context

When annotations are imported into a job, previous annotations are deleted. But after deletion they are kept in memolry for no reason, which can be a problem if they are large.
Dont keep deleted annotations in memory anymore.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Eldies Eldies requested a review from zhiltsov-max as a code owner March 25, 2025 14:11
@Eldies Eldies requested a review from nmanovic as a code owner March 25, 2025 14:12
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.16%. Comparing base (2f110e5) to head (910a3e4).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9256      +/-   ##
===========================================
- Coverage    74.17%   74.16%   -0.01%     
===========================================
  Files          428      428              
  Lines        44964    44968       +4     
  Branches      3917     3917              
===========================================
  Hits         33352    33352              
- Misses       11612    11616       +4     
Components Coverage Δ
cvat-ui 77.21% <ø> (-0.02%) ⬇️
cvat-server 71.63% <90.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants