Add User Agent info to server events #9154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9154 +/- ##
========================================
Coverage 73.32% 73.32%
========================================
Files 448 448
Lines 45862 45867 +5
Branches 3914 3914
========================================
+ Hits 33628 33633 +5
Misses 12234 12234
|
SpecLad
reviewed
Feb 27, 2025
Comment on lines
49
to
+50
| request_id: Optional[str], | ||
| user_agent: Optional[str] = None, |
There was a problem hiding this comment.
Can you merge these into a single parameter (taking a compound object)? Seems like it would be more robust to pass request information as a single parameter, instead of deciding for every call whether the user agent is needed or not.
| **payload, | ||
| "request": { | ||
| **payload.get("request", {}), | ||
| "id": request_id, | ||
| "user-agent": user_agent, |
There was a problem hiding this comment.
Suggested change
| "user-agent": user_agent, | |
| "user_agent": user_agent, |
(I'm pretty sure we're using snake_case in these fields... see working_time.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.