Add HTTP headers to the request #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogajduse
force-pushed
the
feat/add-http-headers-to-request
branch
2 times, most recently
from
9e641d4
to
6dbc55b
Compare
ogajduse
force-pushed
the
feat/add-http-headers-to-request
branch
from
6dbc55b
to
6bddfc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
Some HTTP servers require User-Agent to be present in the request header. This patch adds it to each request that the integration does.
I also found out that elcomercio.es does throws 403 in case User-Agent is not present in the header or if
"feedparser" in headers["User-Agent"]. Which is strange. Therefore the User-Agent value containsfeed-parserinstead of simplefeedparser.