Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: make sure libstandaloneengine gets built first #130

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

bagder
Copy link
Member

@bagder bagder commented Mar 7, 2025

The build can easily break and require a manual 'make libstandaloneengine.a' without this precaution that makes sure the lib is built first.

Ref: #19

The build can easily break and require a manual 'make
libstandaloneengine.a' without this precaution that makes sure the lib
is built first.

Ref: #19
Copy link
Collaborator

@cmeister2 cmeister2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and if you've hit this and this resolves it then even better.

@bagder
Copy link
Member Author

bagder commented Mar 7, 2025

I did try to make clean and make again several times and it worked fine - and the logic seems to match.

I did hit this problem before this fix.

@bagder bagder merged commit b5fbb3a into master Mar 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants