Additional error handling edge cases #356
Open
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mpkorstanje
requested changes
Jan 23, 2025
perl/lib/Gherkin/TokenMatcher.pm
Outdated
| @@ -238,6 +238,9 @@ sub match_StepLine { | |||
|
|
|||
| sub match_DocStringSeparator { | |||
| my ( $self, $token ) = @_; | |||
| if ($token->is_eof) { | |||
| return; | |||
There was a problem hiding this comment.
Other implementations return true/false in _match_DocStringSeparator, which I think should cover this case.
To make it easier for everyone to compare across languages, it would be good to be consistent.
There was a problem hiding this comment.
I added an explicit false/0
obligaron
force-pushed
the
addbadtestdata
branch
from
bc7a7b2 to
6efa4af
Compare
luke-hill
reviewed
Jan 31, 2025
| Scenario: Add two numbers | ||
| When I press | ||
| | foo | | ||
| | bar \ |
There was a problem hiding this comment.
Think this file should be snake cased and there is a newline missing here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
⚡️ What's your motivation?
These error handling edge cases were reported to the .NET implementation and fixed in an upstream project in 2019. Later, these fixes were also merged into the gherkin repository.
While working on some optimisations (see #344), the question arose whether the regression tests should be ported to the gherkin repository. This ensures that all implementations can handle these edge cases that have been reported by users.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
The Perl implementation in general (first time writing Perl 😉), and also whether the required check for EOF should be added to other cases in the Perl implementation (but maybe this is something for another PR).
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.