Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema-compiler): ExportNamedDeclaration for variables object #9390

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Mar 26, 2025

This supersedes the original PR by @arkadiusz-swierczek-pm with some improvements/fixes.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Closes #8774

@KSDaemon KSDaemon marked this pull request as ready for review March 26, 2025 12:50
@KSDaemon KSDaemon requested a review from a team as a code owner March 26, 2025 12:50
@KSDaemon KSDaemon force-pushed the arkadiusz-swierczek-pm-master branch from aebb565 to a70015f Compare March 27, 2025 10:50
Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix LGTM, but any kind of test is required!

@KSDaemon KSDaemon force-pushed the arkadiusz-swierczek-pm-master branch from a70015f to ec880ca Compare April 7, 2025 09:38
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.97%. Comparing base (14ae6a4) to head (58aa81e).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (14ae6a4) and HEAD (58aa81e). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (14ae6a4) HEAD (58aa81e)
cubesql 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9390       +/-   ##
===========================================
- Coverage   76.57%   47.97%   -28.60%     
===========================================
  Files         400      171      -229     
  Lines      105044    21424    -83620     
  Branches     3707     3710        +3     
===========================================
- Hits        80434    10279    -70155     
+ Misses      24174    10706    -13468     
- Partials      436      439        +3     
Flag Coverage Δ
cube-backend 47.97% <100.00%> (+0.11%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the arkadiusz-swierczek-pm-master branch from ec880ca to b1c8cf0 Compare April 8, 2025 17:48
@KSDaemon KSDaemon merged commit b16e8dd into master Apr 8, 2025
59 checks passed
@KSDaemon KSDaemon deleted the arkadiusz-swierczek-pm-master branch April 8, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants