-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(schema-compiler): ExportNamedDeclaration for variables object #9390
Conversation
aebb565
to
a70015f
Compare
packages/cubejs-schema-compiler/src/compiler/transpilers/ImportExportTranspiler.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix LGTM, but any kind of test is required!
a70015f
to
ec880ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9390 +/- ##
===========================================
- Coverage 76.57% 47.97% -28.60%
===========================================
Files 400 171 -229
Lines 105044 21424 -83620
Branches 3707 3710 +3
===========================================
- Hits 80434 10279 -70155
+ Misses 24174 10706 -13468
- Partials 436 439 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ec880ca
to
b1c8cf0
Compare
This supersedes the original PR by @arkadiusz-swierczek-pm with some improvements/fixes.
Check List
Closes #8774