Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tesseract): Don't generate COALESCE with single argument #9300

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

waralexrom
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@waralexrom waralexrom requested a review from a team as a code owner March 4, 2025 18:24
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (0e95f18) to head (f180225).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9300   +/-   ##
=======================================
  Coverage   83.81%   83.81%           
=======================================
  Files         229      229           
  Lines       82658    82658           
=======================================
  Hits        69283    69283           
  Misses      13375    13375           
Flag Coverage Δ
cubesql 83.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@waralexrom waralexrom force-pushed the tesseract-coalesce-fix branch from 721634a to 8a62e77 Compare March 6, 2025 09:24
@waralexrom waralexrom merged commit 3174be1 into master Mar 6, 2025
74 checks passed
@waralexrom waralexrom deleted the tesseract-coalesce-fix branch March 6, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants