Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema-compiler): Fix ORDER BY clause generation for queries with td with filters #9296

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix(schema-compiler): Fix ORDER BY clause generation for queries with td with filters #9296

merged 2 commits into from
Mar 5, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Mar 3, 2025 •
edited
Loading

This PR fixes incorrect ORDER BY clause generation for queries with time dimensions with dateRanges.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon marked this pull request as ready for review March 4, 2025 09:13
@KSDaemon KSDaemon requested a review from a team as a code owner March 4, 2025 09:13
@ovr ovr requested a review from waralexrom March 5, 2025 16:10
@ovr
Copy link
Member

ovr commented Mar 5, 2025 •
edited
Loading

@waralex Please take a look! /related tesseract

@KSDaemon KSDaemon merged commit 1c8ce4f into master Mar 5, 2025
55 checks passed
@KSDaemon KSDaemon deleted the fix/sort-order branch March 5, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovr ovr ovr approved these changes

@waralexrom waralexrom waralexrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KSDaemon @ovr @waralexrom