feat(tesseract): Pre-aggregation planning fallback #9230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9230 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 228 228
Lines 82016 82016
=======================================
Hits 68640 68640
Misses 13376 13376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
KSDaemon
reviewed
Feb 26, 2025
| @@ -278,11 +278,9 @@ export class BaseQuery { | |||
| return dimension; | |||
| }).filter(R.identity).map(this.newTimeDimension.bind(this)); | |||
| this.allFilters = this.timeDimensions.concat(this.segments).concat(this.filters); | |||
| this.useNativeSqlPlanner = this.options.useNativeSqlPlanner ?? getEnv('nativeSqlPlanner'); | |||
There was a problem hiding this comment.
It would be good to add .default('false') to this env so the useNativeSqlPlanner can be always bool.
| @@ -603,33 +609,61 @@ export class BaseQuery { | |||
| return false; | |||
| } | |||
|
|
|||
| newQueryNotUseNative() { | |||
There was a problem hiding this comment.
Suggested change
| newQueryNotUseNative() { | |
| newQueryWithoutNative() { |
Comment on lines
+640
to
+652
| if (this.options.disableExternalPreAggregations && preAggForQuery && preAggForQuery.preAggregation.external) { | ||
| preAggForQuery = undefined; | ||
| } | ||
| if (preAggForQuery) { | ||
| isRelatedToPreAggregation = true; |
There was a problem hiding this comment.
It looks like these 2 ifs can be combined into one. Smth like:
if (!(this.options.disableExternalPreAggregations &&
preAggForQuery &&
preAggForQuery.preAggregation.external)) {
isRelatedToPreAggregation = true;There was a problem hiding this comment.
The current version seems more readable to me. In any case, this is a very temporary solution
| @@ -2960,6 +2994,7 @@ export class BaseQuery { | |||
| } | |||
|
|
|||
| newSubQueryForCube(cube, options) { | |||
| options = { ...options, useNativeSqlPlanner: false }; // We not use tesseract for pre-aggregations generation yet | |||
There was a problem hiding this comment.
Suggested change
| options = { ...options, useNativeSqlPlanner: false }; // We not use tesseract for pre-aggregations generation yet | |
| options = { ...options, useNativeSqlPlanner: false }; // We don't use tesseract for pre-aggregations generation yet |
waralexrom
force-pushed
the
tesseract-exclude-values-from-filter-params
branch
from
06ae94b to
4a80bc5
Compare
waralexrom
force-pushed
the
tesseract-fallback-to-js-on-pre-aggregations
branch
from
ab46752 to
cc70404
Compare
Base automatically changed from
tesseract-exclude-values-from-filter-params
to
master
March 3, 2025 12:56
waralexrom
force-pushed
the
tesseract-fallback-to-js-on-pre-aggregations
branch
from
cc70404 to
10bdac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]