-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jiwon/profile #80
Jiwon/profile #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing first PR Jiwon! You were able to do so much in such a short amount of time, it's most impressive! 🚀
Overall your code seems good, just a few style changes and suggestions that I made, please fix and re-request review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work Jiwon! Thanks for fixing up all the comments!
Sorry for giving so many 😔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Your code is very readable and clean! Amazing work and I especially like the animation that happens when you first open the profile! One thing though, when I saw your demo video attached in your PR, I saw that the circles with check marks for the weekly tracker just kinda appear. I put some suggestions (plz double check em) but it's just to make the workout circles and their check marks fade in. Have a great spring break man!
43f61f1
to
cff62ca
Compare
* Addressed Matt's comments - Removed TabView and used environment object to allow tab bar to be hidden when necessary - Allowed rescaling of font size for class title - Added instructor label * Merge Release to Main (#69) * Add support for custom GraphQL errors * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Update Package.resolved * Updated build number * Release 2.5.8 Build 29 (#68) * Add support for custom GraphQL errors * Update queries * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Optimized filtered classes * Optimized next sessions * Cleaned up code * Update fragments and mutations * Fixed error due to updated mutation * Update project.pbxproj * Create Package.resolved --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Vin Bui <[email protected]> --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> * Fixed spacing of tabbar and transition * Fix spacing of tab bar * Update class detail page navigation - Removed navigation to new pages of class details - Instead updates information on current class detail page when clicking a next sessions cell - Includes animation of scrolling back to top of screen * Fix spelling error * Implement onboarding flow (#75) * Implement start of the sign in view * Implement sign in view * Implement all screens for user onboarding * Implement onboarding UI + photo picker * Implement google sign in - WIP - google sign in works at this point - no networking yet * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Update project.pbxproj * Implement start of the sign in view * Implement all screens for user onboarding * Implement google sign in - WIP - google sign in works at this point - no networking yet * Implement button actions - Revise logic flow - Current implementation works for everything * Resolve slight bug in constants * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Address PR comments * Fix constants * Fix issues w classes PR - also revise app delegate to configure firebase * Fix issue with app delegate again * Address PR comments WIP - still need to address animation * Implement animation transitions b/w screens - Animation from Sign in to main view - Animation from create profile to main view - Refactor the Launching screen conditional logic * Implement animation part 1 - able to get loginButton and skipButton to fade in now * Implement animation part 2 - able to get everything except the bars animated * Finish implement animation (SignInView) * Address second round of PR comments * Change background color logic --------- Co-authored-by: Caitlyn Jin <[email protected]> * Implemented Capacity Reminders UI (#65) * Modified back button and setup reminders screen - Created temporary Profile tab - Set up reminders page - Modified NavBackButton so that it can be initialized with a different color back button * Implemented reminders page - Added capacity reminders cell * Implemented capacity reminders page - Selection UI and toggle reminders - Updated reminders view * Set text to multiline * Add documentation for profile page * Fixed layout issues * Remove duplicate build files * Update project.pbxproj * ten intervals (#81) * Implemented Popular Times (#79) * Changed hours layout * Implemented capacity semi circle for gym detail * Progress on popular times * Implemented popular times - Created chart for popular times - Dummy data for hourly capacities - Updated equipment fragment and model - Removal of equipment type (in progress) * Fix ordering of mdoels * Implemented amenities section * Created reusable drop down arrow * Implemented equipment section * IMplemented popularTimes * Update Uplift/Models/Equipment.swift * Updated Equipment Filtering * Resolved Conflicts * Fixed Range issue * Addressed Jayson's Changes and disabled onboarding --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> * Caitlyn/gym details layout (#82) * Changed hours layout * Implemented capacity semi circle for gym detail * Progress on popular times * Implemented popular times - Created chart for popular times - Dummy data for hourly capacities - Updated equipment fragment and model - Removal of equipment type (in progress) * Fix ordering of mdoels * Implemented amenities section * Created reusable drop down arrow * Implemented equipment section * IMplemented popularTimes * Update Uplift/Models/Equipment.swift * Updated Equipment Filtering * Resolved Conflicts * Fixed Range issue * Addressed Jayson's Changes and disabled onboarding * Comment out profile code --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> * Jiwon/profile (#80) * General Profile Layout * Mock Data + Header * ProgressBar * Animation WorkoutProgressArc * ProfileView Layout * Layout Updated * Edits * minor changes * Edits * Clean up Code * Addressed Richie's Comments * Padding Bug Fixed * Renamed Settings * Added Space * Updated Main View * Addressed Asen's Comments * Changed Debug to Release (#87) * Incremented Version and Build Version --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: belle hu <[email protected]> Co-authored-by: Jayson Hahn <[email protected]> Co-authored-by: Jiwon Jeong <[email protected]>
* Release 3.1.0 Build 36 (#83) * Addressed Matt's comments - Removed TabView and used environment object to allow tab bar to be hidden when necessary - Allowed rescaling of font size for class title - Added instructor label * Merge Release to Main (#69) * Add support for custom GraphQL errors * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Update Package.resolved * Updated build number * Release 2.5.8 Build 29 (#68) * Add support for custom GraphQL errors * Update queries * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Optimized filtered classes * Optimized next sessions * Cleaned up code * Update fragments and mutations * Fixed error due to updated mutation * Update project.pbxproj * Create Package.resolved --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Vin Bui <[email protected]> --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> * Fixed spacing of tabbar and transition * Fix spacing of tab bar * Update class detail page navigation - Removed navigation to new pages of class details - Instead updates information on current class detail page when clicking a next sessions cell - Includes animation of scrolling back to top of screen * Fix spelling error * Implement onboarding flow (#75) * Implement start of the sign in view * Implement sign in view * Implement all screens for user onboarding * Implement onboarding UI + photo picker * Implement google sign in - WIP - google sign in works at this point - no networking yet * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Update project.pbxproj * Implement start of the sign in view * Implement all screens for user onboarding * Implement google sign in - WIP - google sign in works at this point - no networking yet * Implement button actions - Revise logic flow - Current implementation works for everything * Resolve slight bug in constants * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Address PR comments * Fix constants * Fix issues w classes PR - also revise app delegate to configure firebase * Fix issue with app delegate again * Address PR comments WIP - still need to address animation * Implement animation transitions b/w screens - Animation from Sign in to main view - Animation from create profile to main view - Refactor the Launching screen conditional logic * Implement animation part 1 - able to get loginButton and skipButton to fade in now * Implement animation part 2 - able to get everything except the bars animated * Finish implement animation (SignInView) * Address second round of PR comments * Change background color logic --------- Co-authored-by: Caitlyn Jin <[email protected]> * Implemented Capacity Reminders UI (#65) * Modified back button and setup reminders screen - Created temporary Profile tab - Set up reminders page - Modified NavBackButton so that it can be initialized with a different color back button * Implemented reminders page - Added capacity reminders cell * Implemented capacity reminders page - Selection UI and toggle reminders - Updated reminders view * Set text to multiline * Add documentation for profile page * Fixed layout issues * Remove duplicate build files * Update project.pbxproj * ten intervals (#81) * Implemented Popular Times (#79) * Changed hours layout * Implemented capacity semi circle for gym detail * Progress on popular times * Implemented popular times - Created chart for popular times - Dummy data for hourly capacities - Updated equipment fragment and model - Removal of equipment type (in progress) * Fix ordering of mdoels * Implemented amenities section * Created reusable drop down arrow * Implemented equipment section * IMplemented popularTimes * Update Uplift/Models/Equipment.swift * Updated Equipment Filtering * Resolved Conflicts * Fixed Range issue * Addressed Jayson's Changes and disabled onboarding --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> * Caitlyn/gym details layout (#82) * Changed hours layout * Implemented capacity semi circle for gym detail * Progress on popular times * Implemented popular times - Created chart for popular times - Dummy data for hourly capacities - Updated equipment fragment and model - Removal of equipment type (in progress) * Fix ordering of mdoels * Implemented amenities section * Created reusable drop down arrow * Implemented equipment section * IMplemented popularTimes * Update Uplift/Models/Equipment.swift * Updated Equipment Filtering * Resolved Conflicts * Fixed Range issue * Addressed Jayson's Changes and disabled onboarding * Comment out profile code --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> * incremented version and build * Chanegs --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: belle hu <[email protected]> Co-authored-by: Jayson Hahn <[email protected]> Co-authored-by: Jiwon Jeong <[email protected]> * Main copy updated Package.resolved File (#85) * Addressed Matt's comments - Removed TabView and used environment object to allow tab bar to be hidden when necessary - Allowed rescaling of font size for class title - Added instructor label * Merge Release to Main (#69) * Add support for custom GraphQL errors * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Update Package.resolved * Updated build number * Release 2.5.8 Build 29 (#68) * Add support for custom GraphQL errors * Update queries * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Optimized filtered classes * Optimized next sessions * Cleaned up code * Update fragments and mutations * Fixed error due to updated mutation * Update project.pbxproj * Create Package.resolved --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Vin Bui <[email protected]> --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> * Fixed spacing of tabbar and transition * Fix spacing of tab bar * Update class detail page navigation - Removed navigation to new pages of class details - Instead updates information on current class detail page when clicking a next sessions cell - Includes animation of scrolling back to top of screen * Fix spelling error * Implement onboarding flow (#75) * Implement start of the sign in view * Implement sign in view * Implement all screens for user onboarding * Implement onboarding UI + photo picker * Implement google sign in - WIP - google sign in works at this point - no networking yet * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Update project.pbxproj * Implement start of the sign in view * Implement all screens for user onboarding * Implement google sign in - WIP - google sign in works at this point - no networking yet * Implement button actions - Revise logic flow - Current implementation works for everything * Resolve slight bug in constants * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Address PR comments * Fix constants * Fix issues w classes PR - also revise app delegate to configure firebase * Fix issue with app delegate again * Address PR comments WIP - still need to address animation * Implement animation transitions b/w screens - Animation from Sign in to main view - Animation from create profile to main view - Refactor the Launching screen conditional logic * Implement animation part 1 - able to get loginButton and skipButton to fade in now * Implement animation part 2 - able to get everything except the bars animated * Finish implement animation (SignInView) * Address second round of PR comments * Change background color logic --------- Co-authored-by: Caitlyn Jin <[email protected]> * Implemented Capacity Reminders UI (#65) * Modified back button and setup reminders screen - Created temporary Profile tab - Set up reminders page - Modified NavBackButton so that it can be initialized with a different color back button * Implemented reminders page - Added capacity reminders cell * Implemented capacity reminders page - Selection UI and toggle reminders - Updated reminders view * Set text to multiline * Add documentation for profile page * Fixed layout issues * Remove duplicate build files * Update project.pbxproj * ten intervals (#81) * Implemented Popular Times (#79) * Changed hours layout * Implemented capacity semi circle for gym detail * Progress on popular times * Implemented popular times - Created chart for popular times - Dummy data for hourly capacities - Updated equipment fragment and model - Removal of equipment type (in progress) * Fix ordering of mdoels * Implemented amenities section * Created reusable drop down arrow * Implemented equipment section * IMplemented popularTimes * Update Uplift/Models/Equipment.swift * Updated Equipment Filtering * Resolved Conflicts * Fixed Range issue * Addressed Jayson's Changes and disabled onboarding --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> * Caitlyn/gym details layout (#82) * Changed hours layout * Implemented capacity semi circle for gym detail * Progress on popular times * Implemented popular times - Created chart for popular times - Dummy data for hourly capacities - Updated equipment fragment and model - Removal of equipment type (in progress) * Fix ordering of mdoels * Implemented amenities section * Created reusable drop down arrow * Implemented equipment section * IMplemented popularTimes * Update Uplift/Models/Equipment.swift * Updated Equipment Filtering * Resolved Conflicts * Fixed Range issue * Addressed Jayson's Changes and disabled onboarding * Comment out profile code --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> * incremented version and build * Chanegs * Updated package.resolved file --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: belle hu <[email protected]> Co-authored-by: Jayson Hahn <[email protected]> Co-authored-by: Jiwon Jeong <[email protected]> * Updated Package Configs (#86) * Addressed Matt's comments - Removed TabView and used environment object to allow tab bar to be hidden when necessary - Allowed rescaling of font size for class title - Added instructor label * Merge Release to Main (#69) * Add support for custom GraphQL errors * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Update Package.resolved * Updated build number * Release 2.5.8 Build 29 (#68) * Add support for custom GraphQL errors * Update queries * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Optimized filtered classes * Optimized next sessions * Cleaned up code * Update fragments and mutations * Fixed error due to updated mutation * Update project.pbxproj * Create Package.resolved --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Vin Bui <[email protected]> --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> * Fixed spacing of tabbar and transition * Fix spacing of tab bar * Update class detail page navigation - Removed navigation to new pages of class details - Instead updates information on current class detail page when clicking a next sessions cell - Includes animation of scrolling back to top of screen * Fix spelling error * Implement onboarding flow (#75) * Implement start of the sign in view * Implement sign in view * Implement all screens for user onboarding * Implement onboarding UI + photo picker * Implement google sign in - WIP - google sign in works at this point - no networking yet * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Update project.pbxproj * Implement start of the sign in view * Implement all screens for user onboarding * Implement google sign in - WIP - google sign in works at this point - no networking yet * Implement button actions - Revise logic flow - Current implementation works for everything * Resolve slight bug in constants * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Address PR comments * Fix constants * Fix issues w classes PR - also revise app delegate to configure firebase * Fix issue with app delegate again * Address PR comments WIP - still need to address animation * Implement animation transitions b/w screens - Animation from Sign in to main view - Animation from create profile to main view - Refactor the Launching screen conditional logic * Implement animation part 1 - able to get loginButton and skipButton to fade in now * Implement animation part 2 - able to get everything except the bars animated * Finish implement animation (SignInView) * Address second round of PR comments * Change background color logic --------- Co-authored-by: Caitlyn Jin <[email protected]> * Implemented Capacity Reminders UI (#65) * Modified back button and setup reminders screen - Created temporary Profile tab - Set up reminders page - Modified NavBackButton so that it can be initialized with a different color back button * Implemented reminders page - Added capacity reminders cell * Implemented capacity reminders page - Selection UI and toggle reminders - Updated reminders view * Set text to multiline * Add documentation for profile page * Fixed layout issues * Remove duplicate build files * Update project.pbxproj * ten intervals (#81) * Implemented Popular Times (#79) * Changed hours layout * Implemented capacity semi circle for gym detail * Progress on popular times * Implemented popular times - Created chart for popular times - Dummy data for hourly capacities - Updated equipment fragment and model - Removal of equipment type (in progress) * Fix ordering of mdoels * Implemented amenities section * Created reusable drop down arrow * Implemented equipment section * IMplemented popularTimes * Update Uplift/Models/Equipment.swift * Updated Equipment Filtering * Resolved Conflicts * Fixed Range issue * Addressed Jayson's Changes and disabled onboarding --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> * Caitlyn/gym details layout (#82) * Changed hours layout * Implemented capacity semi circle for gym detail * Progress on popular times * Implemented popular times - Created chart for popular times - Dummy data for hourly capacities - Updated equipment fragment and model - Removal of equipment type (in progress) * Fix ordering of mdoels * Implemented amenities section * Created reusable drop down arrow * Implemented equipment section * IMplemented popularTimes * Update Uplift/Models/Equipment.swift * Updated Equipment Filtering * Resolved Conflicts * Fixed Range issue * Addressed Jayson's Changes and disabled onboarding * Comment out profile code --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> * incremented version and build * Chanegs * Updated package.resolved file * Updated Uplift Package Configs --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: belle hu <[email protected]> Co-authored-by: Jayson Hahn <[email protected]> Co-authored-by: Jiwon Jeong <[email protected]> * Release 3.1.1 Build 38 (#88) * Addressed Matt's comments - Removed TabView and used environment object to allow tab bar to be hidden when necessary - Allowed rescaling of font size for class title - Added instructor label * Merge Release to Main (#69) * Add support for custom GraphQL errors * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Update Package.resolved * Updated build number * Release 2.5.8 Build 29 (#68) * Add support for custom GraphQL errors * Update queries * Remove codegen build phase * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Comment out giveaway modal on home * Optimized filtered classes * Optimized next sessions * Cleaned up code * Update fragments and mutations * Fixed error due to updated mutation * Update project.pbxproj * Create Package.resolved --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Vin Bui <[email protected]> --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> * Fixed spacing of tabbar and transition * Fix spacing of tab bar * Update class detail page navigation - Removed navigation to new pages of class details - Instead updates information on current class detail page when clicking a next sessions cell - Includes animation of scrolling back to top of screen * Fix spelling error * Implement onboarding flow (#75) * Implement start of the sign in view * Implement sign in view * Implement all screens for user onboarding * Implement onboarding UI + photo picker * Implement google sign in - WIP - google sign in works at this point - no networking yet * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Update project.pbxproj * Implement start of the sign in view * Implement all screens for user onboarding * Implement google sign in - WIP - google sign in works at this point - no networking yet * Implement button actions - Revise logic flow - Current implementation works for everything * Resolve slight bug in constants * Implemented classes page - Performed soft reset and squashing the previous commits - Implemented ClassesView, ClassCell, ClassDetailView, NextSessionCell, and ClassesViewModel - Created FitnessClass and FitnessClassInstance models - Other modifications to create the classes screens * Address PR comments * Fix constants * Fix issues w classes PR - also revise app delegate to configure firebase * Fix issue with app delegate again * Address PR comments WIP - still need to address animation * Implement animation transitions b/w screens - Animation from Sign in to main view - Animation from create profile to main view - Refactor the Launching screen conditional logic * Implement animation part 1 - able to get loginButton and skipButton to fade in now * Implement animation part 2 - able to get everything except the bars animated * Finish implement animation (SignInView) * Address second round of PR comments * Change background color logic --------- Co-authored-by: Caitlyn Jin <[email protected]> * Implemented Capacity Reminders UI (#65) * Modified back button and setup reminders screen - Created temporary Profile tab - Set up reminders page - Modified NavBackButton so that it can be initialized with a different color back button * Implemented reminders page - Added capacity reminders cell * Implemented capacity reminders page - Selection UI and toggle reminders - Updated reminders view * Set text to multiline * Add documentation for profile page * Fixed layout issues * Remove duplicate build files * Update project.pbxproj * ten intervals (#81) * Implemented Popular Times (#79) * Changed hours layout * Implemented capacity semi circle for gym detail * Progress on popular times * Implemented popular times - Created chart for popular times - Dummy data for hourly capacities - Updated equipment fragment and model - Removal of equipment type (in progress) * Fix ordering of mdoels * Implemented amenities section * Created reusable drop down arrow * Implemented equipment section * IMplemented popularTimes * Update Uplift/Models/Equipment.swift * Updated Equipment Filtering * Resolved Conflicts * Fixed Range issue * Addressed Jayson's Changes and disabled onboarding --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> * Caitlyn/gym details layout (#82) * Changed hours layout * Implemented capacity semi circle for gym detail * Progress on popular times * Implemented popular times - Created chart for popular times - Dummy data for hourly capacities - Updated equipment fragment and model - Removal of equipment type (in progress) * Fix ordering of mdoels * Implemented amenities section * Created reusable drop down arrow * Implemented equipment section * IMplemented popularTimes * Update Uplift/Models/Equipment.swift * Updated Equipment Filtering * Resolved Conflicts * Fixed Range issue * Addressed Jayson's Changes and disabled onboarding * Comment out profile code --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> * Jiwon/profile (#80) * General Profile Layout * Mock Data + Header * ProgressBar * Animation WorkoutProgressArc * ProfileView Layout * Layout Updated * Edits * minor changes * Edits * Clean up Code * Addressed Richie's Comments * Padding Bug Fixed * Renamed Settings * Added Space * Updated Main View * Addressed Asen's Comments * Changed Debug to Release (#87) * Incremented Version and Build Version --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: belle hu <[email protected]> Co-authored-by: Jayson Hahn <[email protected]> Co-authored-by: Jiwon Jeong <[email protected]> --------- Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Caitlyn Jin <[email protected]> Co-authored-by: Vin Bui <[email protected]> Co-authored-by: belle hu <[email protected]> Co-authored-by: Jayson Hahn <[email protected]> Co-authored-by: Jiwon Jeong <[email protected]>
Overview
Finished the main profile UI with animation. Keep in mind this is only dummy data and fetchuserprofile function is just fetching dummy data corresponding to the figma file. (will change it later when we have network requests)
Changes Made
Change 1
Change 2
Next Steps (optional)
Screenshots
Main UI Profile Page
Screen.Recording.2025-03-16.at.2.42.17.PM.mov