Implement navigation and past games screen UI/ViewModel/majority of networking #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachseidner1
requested changes
Mar 20, 2025
There was a problem hiding this comment.
Helen, this is a really impressive first draft! Everything looks nice overall, and I am hoping that after resolving the merge conflicts and taking a look at my comments you should be good. Please try to do this as soon as you reasonably can in case I end up having more comments, since we want to make sure this gets in in time. You did some real clever stuff in this PR that I even learned something lol.
| gradientColor1: Color, | ||
| gradientColor2: Color, | ||
| modifier: Modifier = Modifier | ||
| ) { | ||
| val isPast = (leftScore != null && rightScore != null) |
There was a problem hiding this comment.
This is business logic, we should move it out of the view. We should probably pass this in as a parameter to FeaturedGameHeader instead.
app/src/main/java/com/cornellappdev/score/components/FeaturedGameCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/viewmodel/PastGamesViewModel.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implemented Past Games (aka Scores) screen, with the associated ViewModel and most of networking. Also implemented bottom bar and navigation between game cards (on both Home and Past Games Screen) to a dummy game details screen.
Changes Made
UpcomingGameCardtoFeaturedGameCard,SportCardtoGameCard,UpcomingGamesCarouseltoGamesCarousel)PastGameCardandPastGamesScreen(PastGameCards are properly spaced on this screen)PastGamesViewModelGameCard/PastGameCardto a dummyGameDetailsPage-- will currently navigate back to the correct page when clicking the back arrow on theGameDetailsScreenPastGamesScreenGameCardso long event/university names don't push the sport/gender icon off the cardAdditional Notes
resultstring, which is oftentimes in the format Result, CornellScore-OpponentScore (e.g. "W, 2-1"). Not all of the strings are in this format (e.g. 4th of 6, 1498 points for women's Swimming and Diving), but in this case, thecornellScoreandotherScoreparameters of the game and associated card should be null, and as of right now, null-scored games are filtered out.