Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bet Tracker View #14

Merged
merged 15 commits into from
Mar 24, 2025
Merged

Bet Tracker View #14

merged 15 commits into from
Mar 24, 2025

Conversation

JiwonJeong414
Copy link
Contributor

Implemented the Bet Tracker View with custom charts and cards. Mostly used Peter's code for dummy data which was really helpful. The helper functions for calculating the gains and losses might be incorrect (need review)

Todo:

  • add custom back button for the FAQ
  • better charts styling for monthly view
  • add the final cards in the button after those are done
  • replace dummy data with actual data

Ant's Dummy Data
Screenshot 2025-03-20 at 7 55 51 PM

Peter's Dummy Data
Screenshot 2025-03-20 at 7 56 48 PM

Video:

Screen.Recording.2025-03-20.at.7.56.04.PM.mov

Copy link
Contributor

@antoinztte antoinztte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me speak w/ designers about the Monthly view of the chart + the specific sizing before you push this. Everything else LGTM!

@antoinztte
Copy link
Contributor

Let's fix the back arrow for FAQ page to reflect the Figma!

@JiwonJeong414 JiwonJeong414 force-pushed the jiwon/bet-tracker-page branch from f3f78ac to f1b0212 Compare March 22, 2025 23:56
@JiwonJeong414
Copy link
Contributor Author

Updated View:

  • fixed monthly view
  • fixed faq view
  • fixed back button view
Screen.Recording.2025-03-23.at.2.18.53.PM.mov

Copy link
Collaborator

@MrPeterss MrPeterss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work Jiwon! I trust you can fix the few comments I left before merging. Keep it up!

@JiwonJeong414 JiwonJeong414 dismissed antoinztte’s stale review March 23, 2025 21:35

Ant is very busy right now and her laptop is not with her

@JiwonJeong414 JiwonJeong414 requested a review from AdelynnWu March 23, 2025 21:36
Copy link
Contributor

@AdelynnWu AdelynnWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@JiwonJeong414 JiwonJeong414 merged commit e5fb2f9 into main Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants