Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routes markdown #429

Merged
merged 2 commits into from
Dec 17, 2016
Merged

Routes markdown #429

merged 2 commits into from
Dec 17, 2016
+147 −41

Conversation

ryanfox1985
Copy link
Contributor

Implemented routes in markdown, closes #178

@ryanfox1985 ryanfox1985 mentioned this pull request Dec 17, 2016
Closed
@ctran
Copy link
Owner

ctran commented Dec 17, 2016 •
edited
Loading

@ryanfox1985 Could you remove the change in .rubocop_tody.yml? It's causing conflicts.

@ctran ctran self-requested a review December 17, 2016 01:38
@ctran ctran added this to the v2.7.2 milestone Dec 17, 2016
@ryanfox1985
Copy link
Contributor Author

rebased

@ryanfox1985
Copy link
Contributor Author

I think that I have a mistake in markdown. Let me check.

@ryanfox1985
Implemented routes in markdown, closes ctran#178
07da56d 
Fixed if element in table contains pipe char.
@ryanfox1985
Copy link
Contributor Author

Yes, I corrected, the element in the table can has the char pipe | and has a trouble with the table markdown. Now it's ready.

@ctran ctran merged commit d108ba8 into ctran:develop Dec 17, 2016
johncarney pushed a commit to johncarney/annotate_models that referenced this pull request Jun 19, 2017
@ryanfox1985 @johncarney
Routes markdown (ctran#429)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
50155fe 
* --active-admin replaced as a flag.
closes ctran#363.

* Implemented routes in markdown, closes ctran#178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctran ctran

Assignees

@ryanfox1985 ryanfox1985

Labels
None yet
Projects
None yet
Milestone
v2.7.2
Development

Successfully merging this pull request may close these issues.

Annotating routes doesn't support markdown option
2 participants
@ryanfox1985 @ctran