Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new swat dtype definition #235

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Add new swat dtype definition #235

merged 1 commit into from
Nov 26, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 25, 2024

No description provided.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.97%. Comparing base (0c553fc) to head (65b6a4d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ctapipe_io_lst/__init__.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   91.09%   90.97%   -0.13%     
==========================================
  Files          25       25              
  Lines        2629     2637       +8     
==========================================
+ Hits         2395     2399       +4     
- Misses        234      238       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested it and it works

@morcuended morcuended merged commit 247104c into main Nov 26, 2024
7 of 9 checks passed
@morcuended morcuended deleted the update_swat_data branch November 26, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants