This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[TIZEN][EFL] Add imageFilenameExtension API to WebElement #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180403 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Don't repaint squashed, fixed position layers during scrolling > > There's no need to repaint fixed position layers that are squashed. Necessarily > they must be squashed onto other fixed position layers, which means they don't > move during scrolling. > > [email protected] > > Review URL: https://codereview.chromium.org/478823002 [email protected] Review URL: https://codereview.chromium.org/489883003 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180668 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Invisible fixed-position elements should not trigger main thread scrolling > > There no reason to scroll on the main thread if the only non-composited fixed > position elements are invisible. > > [email protected] > BUG=404332 > > Review URL: https://codereview.chromium.org/481223002 [email protected] Review URL: https://codereview.chromium.org/491933002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180669 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Fix crash on GestureTap in Node::commonAncestor > > When doing a tap, if the synthetic mousedown lands on some node, but > changes the DOM such that there's no node at that point afterwards > (eg. a frame scrollbar), then we'll pass a null node pointer to > commonAncestor and crash. > > In addition to adding a test for this case (the mousedown case in > gesture-tap-frame-scrollbar) I added tests for a number of similar > cases (null hit test and removed node) that are already working > correctly but could be subject to similar bugs. > > Also corrected a minor typo in a related test > (gesture-tap-click-common-ancestor) - doesn't change behavior, just > better reflects the intention of the test (the ancestor node itself > should not be hittable). > > BUG=402338 > > Review URL: https://codereview.chromium.org/466143005 [email protected] Review URL: https://codereview.chromium.org/496533002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180678 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> input[type=date] warns if specified string is invalid. > > We show a console message if: > - An invalid string is set to 'value' IDL attribute. > - An invalid string is set to 'value' content attribute. > - 'date' is set to 'type' attribute and existing 'value' content attribute is > invalid. > - 'date' is set to 'type' attribute and existing user-specified value is > invalid. > > BUG=397952 > TEST=Update expectations of automated tests. > > Review URL: https://codereview.chromium.org/461323006 [email protected] BUG=397952,405227 Review URL: https://codereview.chromium.org/492123002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180690 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> DevTools: NetworkPanel: get rid of stripes gradient. > > Rendering gradient consumes considerable amount of time. > > BUG=316092 > > Review URL: https://codereview.chromium.org/440853002 [email protected] Review URL: https://codereview.chromium.org/495893002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180698 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> [DevTools] Show focus outline for inputs everywhere except dialogs. > > BUG=398840 > > Review URL: https://codereview.chromium.org/483663002 [email protected] Review URL: https://codereview.chromium.org/496653002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180704 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Oilpan: Fix conservative marking of objects with uninitialized vtables. > > I used Visitor::markNoTracing but that is only implemented for > the object pointer and not for header pointers. This change > implements markNoTracing for header pointers and adds a regression > test. > > [email protected], [email protected], [email protected] > BUG=404511 > > Review URL: https://codereview.chromium.org/487683002 [email protected] Review URL: https://codereview.chromium.org/495303002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180761 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> DevTools: [CodeMirror] handle new-lines in error popovers > > Add support to new-line character handling in error and warning console > message texts which are shown in a popover in editor. > > BUG=404380 > R=vsevik > > Review URL: https://codereview.chromium.org/478963002 [email protected] Review URL: https://codereview.chromium.org/469643003 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180772 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Minimal fix to gesture event frame targetting > > We intended to handle gesture events in the frame of the best touch > adjustment node. But HitTestResult::resolveRectBaseTest failed to > update the m_innerNonSharedNode field, leaving just the last candidate > from the rect-based hit test. EventHandler::handleGestureEvent then > ended up using this via HitTestResult::innerNodeFrame() sending events > to possibly the incorrect frame. > > This is a low-risk fix for merging back to M38 which just sets the > missing m_innerNonSharedNode field. But there are deeper pre-existing > issues here that I plan to fix shortly - I've summarized them with > FIXME comments. > > BUG=401504 > > Review URL: https://codereview.chromium.org/487663003 [email protected] Review URL: https://codereview.chromium.org/503433002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180786 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Windows: Fix crash by starting pan-scrolling when render tree needs to be updated. > > It's possible that RenderBox::canBeScrolledAndHasScrollableArea() > modifies render tree and the |while| loop in Node::defaultEventHandler > is confused. We should make sure render tree is up-to-date before the > loop. > > BUG=401362 > > Review URL: https://codereview.chromium.org/471373002 [email protected] Review URL: https://codereview.chromium.org/502823002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180836 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Don't require main-thread scrolling for Gmail > > In Gmail, the FrameView doesn't scroll, which means we don't create a > composited layer for fixed position elements. However, when checking for > main-thread scrolling reasons, we'd notice these non-composited fixed-position > elements and think that meant we needed main-thread scrolling. > > This CL skips the check for non-composited fixed-position elements if the > FrameView isn't scrollable. If the FrameView isn't scrollable, there's no > reason to force main thread scrolling in this case. > > [email protected] > BUG=404332 > > Review URL: https://codereview.chromium.org/480573007 [email protected] Review URL: https://codereview.chromium.org/499973002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180841 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Revert of [XHR] Reduce 'readystatechange' event firing. (patchset crosswalk-project#9 of https://codereview.chromium.org/428473005/) > > Reason for revert: > This change breaks legacy applications. > > Original issue's description: > > [XHR] Reduce 'readystatechange' event firing. > > > > Currently too many readystatechange events are fired and > > it hurts performance. > > > > BUG=336066 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179381 > > Review URL: https://codereview.chromium.org/486133002 [email protected], [email protected] Review URL: https://codereview.chromium.org/499273002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180845 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Fix mapRectToPaintInvalidationBacking() wrong callers > > Previously the callers called mapRectToPaintInvalidationBacking with > wrong parameters (passing paintInvalidationState pointer as 'bool fixed' > and the actual paintInvalidationState was 0). > > As the 'bool fixed' parameter is only meaningful for RenderView, this > change removed the parameter from mapRectToPaintInvalidationBacking, > added RenderView::mapRectToPaintInvalidationBackingOfView() and let > RenderBox call the latter when the container is RenderView. > > For previous wrong callers, > - RenderInline: disable paintInvalidationState offset caching because of > crbug.com/402994 > - RenderLayer: disable paintInvalidationState offset caching because of > crbug.com/402983 > > The change in RenderInline fixes bug 402362. Previously as the 'fixed' > parameter was wrongly passed as 'true', the scroll offset of the view was > wrongly added to the repaint rect of some inlines. > > BUG=403979,402994,402983 > TEST=fast/repaint/inline-style-change-in-scrolled-view.html > TEST=svg/repaint/repaint-in-scrolled-view.html > > Review URL: https://codereview.chromium.org/455253003 [email protected] Review URL: https://codereview.chromium.org/504913002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180859 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Reason for revert: Caused crashes in ImageQualityController::highQualityRepaintTimerFired(). > Oilpan: Move more code of RenderObject destructors to destroy(). > > Like [1] and [2]. We should do it in general. > > [1] http://src.chromium.org/viewvc/blink?view=revision&revision=180023 > [2] http://src.chromium.org/viewvc/blink?view=revision&revision=180029 > > BUG=398342 > > Review URL: https://codereview.chromium.org/459353002 [email protected] BUG=404529 Review URL: https://codereview.chromium.org/492183003 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180871 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Fix a crash for extractSmartClipData > > Position::document() returns null if -webkit-user-select is set to none. > This CL prevents the crash in this case. Also adds a test to make sure > that the crash does not happen and clip text and clip html are empty. > > TEST=passed WebViewTest > BUG=402371 > > Review URL: https://codereview.chromium.org/455133003 [email protected] Review URL: https://codereview.chromium.org/485293005 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180878 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Hide video controls after touch from hideMediaControlsTimerFired. > > BUG=401159 > > Review URL: https://codereview.chromium.org/441193003 [email protected] Review URL: https://codereview.chromium.org/508563002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180894 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> DevTools: [Elements] fix ctrl-z behavior. > > There used to be an assumption that ctrl-z event is coming from elements > tree outline. This turned out to be wrong in case of focused styles > sidebar pane, which caused ctrl-z event to be ignored. > > BUG=405058 > R=pfeldman > > Review URL: https://codereview.chromium.org/484223002 [email protected] Review URL: https://codereview.chromium.org/505183002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180905 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> DevTools: [SSP] Do not re-show color popover after going full-screen > > R=eustas, lushnikov > BUG=404555 > > Review URL: https://codereview.chromium.org/486633002 [email protected] Review URL: https://codereview.chromium.org/504243002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180907 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Defer call to updateWidgetPositions() outside of RenderLayerScrollableArea. > > updateWidgetPositions() can destroy the render tree, so it should never > be called from inside RenderLayerScrollableArea. Leaving it there allows > for the potential of use-after-free bugs. > > BUG=402407 > [email protected] > > Review URL: https://codereview.chromium.org/490473003 [email protected] Review URL: https://codereview.chromium.org/502413003 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180914 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> DevTools: [SSP] update SSP when css model gets enabled. > > There was a typo in the code responsible for the styles sidebar pane > update whenever the css model gets enabled. The patch fixes the typo. > > BUG=400000 > TBR=pfeldman > R=vsevik > > Review URL: https://codereview.chromium.org/495933002 [email protected] Review URL: https://codereview.chromium.org/508273002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@180996 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> [DevTools] Do not instantiate WebInspector.Toolbox in main. > > Toolbox creates itself in a separate DOMContentLoaded listener. > > BUG=391566,405084 > > Review URL: https://codereview.chromium.org/487343002 [email protected] Review URL: https://codereview.chromium.org/514943004 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@181019 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Check m_contentsLayer before reaching into it > > Use clearContentsLayerIfUnregistered set m_contentsLayer to NULL > in case it is now an invalid pointer. > > BUG=399783 (for the crash) > BUG=403682 (maybe) > > Review URL: https://codereview.chromium.org/488473002 [email protected] Review URL: https://codereview.chromium.org/520433003 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@181063 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Regression: r170111 Tapping listbox items should fire change/input event > > BUG=403184 > > Review URL: https://codereview.chromium.org/486583002 [email protected] Review URL: https://codereview.chromium.org/520513002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@181069 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Fix tap target consistency with link highlighting and hover/active > > Touch adjustment doesn't always return the correct node for a point. > This used to be masked by extra hit tests, but in crbug.com/381728 > I attempted to remove redundant hit tests for better performance. > I added an explicit redundant hit-test back in crbug.com/396652 but > only for the tap event handling, not for GestureShowPress. This moves > that temporary additional hit-test back so that it applies to all > types of gesture events that involve touch adjustment. > > > BUG=405508 > > Review URL: https://codereview.chromium.org/499433003 [email protected] Review URL: https://codereview.chromium.org/523693002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@181104 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Fix selection residue in sub-pixel positioned element > > We are inconsistent when invalidating and painting sub-pixel positioned > selections. See the bug for details. > > This change add back the enclosingIntRect() calls that were removed in > http://src.chromium.org/viewvc/blink?view=rev&revision=177408. This is > needed before we fix the inconsistency. > > BUG=394698 > TEST=editing/selection/subpixel-positioned-selection.html > > Review URL: https://codereview.chromium.org/464143003 [email protected] Review URL: https://codereview.chromium.org/523523003 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@181108 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Fix a bug in Image::imageForDefaultFrame() when image anim. is finished > > Image::imageForDefaultFrame() is supposed to return the poster frame > of an animated image (or the first frame) but it was returning the > current frame when called on an image for which the animation is > finished (the laest frame then). > > This, because the Image::maybeAnimated() method returns false when the > animation is finished. > > A new method isAnimated() has been added that only checks the number > of frames in the image to decide if the image is animated or not. > > BUG=286673,405161 > > Review URL: https://codereview.chromium.org/474353002 [email protected] Review URL: https://codereview.chromium.org/519893002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@181112 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Fix accalerated 2D canvas not explicitly invalidating the canvas content layer on update. > > The the call to RenderObject::invalidatePaintRectangle in > HTMLCanvasElement only propagates to the canvas' containing layer > and not the child canvas layer that actually has the canvas content > in the case of an accelerated canvas. This is not a problem as far as > graphics updates are concerned, but it fails to activate the > compositor's rate limiter. The regression was caused by r176815 and > continued to exist after r179637 (patches that refactor canvas > invalidations). > > BUG=404955 > > Review URL: https://codereview.chromium.org/462403003 [email protected] Review URL: https://codereview.chromium.org/519913002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@181115 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Let FrameSelection::updateAppearance call layout explicitly for range. > > In L1608 selection::visibleStart(), we create VisilePosition which constructor > can call layout. > It can change Node::renderer() and Position::isCandidate() value. > The situation happens when user selects an autocomlete item in input element. > Thus we call layout explicitly. > > BUG=404560, 404969 > > Review URL: https://codereview.chromium.org/492983002 [email protected] Review URL: https://codereview.chromium.org/525233002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@181141 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Fix crash by adding a form control to an element. > > This CL fixes a null pointer dereference in the following scenario: > > 1. A form control and a <form> element are associated by HTML parser, and the > <form> is not an ancestor of the form control. > 2. Their common ancestor is detached from the document. > 3. GC happens. The <form> is collected and the form control survives. > 4. The form control is added to an element. > > Usually FormAssociatedElement::m_form is never null if > FormAssociatedElement::m_formWasSetByParser is true. However it can be null. > Blink r179263 [1] exposed this issue because we stopeed to support null Node > pointer in highestAncestorOrSelf() > > [1] http://src.chromium.org/viewvc/blink?view=revision&revision=179263 > > BUG=403088 > > Review URL: https://codereview.chromium.org/481363002 [email protected] Review URL: https://codereview.chromium.org/531443002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@181142 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
This PR is recreated on PR #20, lgtm. |
junmin-zhu
pushed a commit
to junmin-zhu/blink-crosswalk
that referenced
this pull request
Sep 22, 2014
…mpatible to tcmalloc [email protected] TEST=Compile Android build with Deep Memory Profiler support. Go to lenta.ru. Open some news pages. Should not crash. ********** Crash dump: ********** Build fingerprint: 'samsung/GT-I9100/GT-I9100:4.0.3/IML74K/XXLPQ:user/release-keys' pid: 3431, tid: 3444 >>> org.chromium.content_shell_apk:sandboxed_process1 <<< signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000039 Stack frame #00 pc 02263b44 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Abort in ../../third_party/tcmalloc/chromium/src/base/abort.cc:15 Stack frame crosswalk-project#1 pc 0226ccd8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Log in ../../third_party/tcmalloc/chromium/src/internal_logging.cc:120 Stack frame crosswalk-project#2 pc 0227584c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine InvalidFree in (null):0 Stack frame crosswalk-project#3 pc 02277698 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free_with_callback in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1166 Stack frame crosswalk-project#4 pc 02277898 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1209 Stack frame crosswalk-project#5 pc 0229f914 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine tc_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1569 Stack frame crosswalk-project#6 pc 0158af50 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine error in (null):0 Stack frame crosswalk-project#7 pc 0158aff8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine normalErrorHandler in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:1305 Stack frame crosswalk-project#8 pc 01166dac /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __xmlRaiseError in ../../third_party/libxml/src/error.c:572 Stack frame crosswalk-project#9 pc 0116b7a8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlFatalErr in (null):0 Stack frame crosswalk-project#10 pc 0117e424 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseTryOrFinish in ../../third_party/libxml/src/parser.c:11453 Stack frame crosswalk-project#11 pc 0117ea88 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseChunk in ../../third_party/libxml/src/parser.c:11767 Stack frame crosswalk-project#12 pc 0158891c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine parseChunk in (null):0 Stack frame crosswalk-project#13 pc 01589da0 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine doWrite in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:876 Stack frame crosswalk-project#14 pc 01589f3c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine append in ../../third_party/WebKit/Source/wtf/RefPtr.h:49 Stack frame crosswalk-project#15 pc 00d07e70 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine setContent in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70 Stack frame crosswalk-project#16 pc 015770bc /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXML in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70 Stack frame crosswalk-project#17 pc 017bdd20 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetter in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:47 Stack frame crosswalk-project#18 pc 017bddc8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetterCallback in gen/blink/bindings/V8XMLHttpRequest.cpp:219 Stack frame crosswalk-project#19 pc 00eb86d8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Call in ../../v8/src/arguments.cc:110 Stack frame crosswalk-project#20 pc 01024b5c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetPropertyWithCallback in ../../v8/src/objects.cc:443 Stack frame crosswalk-project#21 pc 010304c8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:971 Stack frame crosswalk-project#22 pc 010305dc /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:845 Stack frame crosswalk-project#23 pc 00fb12f8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Load in ../../v8/src/ic.cc:875 Stack frame crosswalk-project#24 pc 00fb1b78 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __RT_impl_LoadIC_Miss in ../../v8/src/ic.cc:2076 Stack frame crosswalk-project#25 pc 00fb1bd0 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine LoadIC_Miss in (null):0 Review URL: https://codereview.chromium.org/143903018 git-svn-id: svn://svn.chromium.org/blink/trunk@166520 bbb929c8-8fbe-4397-9dbb-9b2b20218538
|
After the PR was created, we agreed to use https://github.com/crosswalk-project/blink-crosswalk-efl for the EFL implementation, please resubmit there. |
rakuco
force-pushed
the
master
branch
3 times, most recently
from
6e19c2e to
811052a
Compare
rakuco
force-pushed
the
master
branch
2 times, most recently
from
96e25f2 to
242372e
Compare
Bysmyyr
pushed a commit
to Bysmyyr/blink-crosswalk
that referenced
this pull request
Jul 10, 2015
…lk-project#21 id:400001 of https://codereview.chromium.org/1134523002/) Reason for revert: Reverting once again because this makes ScriptContextSetTest.LifeCycle leak: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/12840/steps/extensions_unittests%20%28with%20patch%29/logs/stdio The reason is that many of these tests do things backwards: they first initialize Blink and then create a message loop. This means we can't create a real scheduler for Blink and have to jump through hoops to make things work. We could extend this mock scheduler to properly clean things up, but I think I'll instead try to get rid of the mock scheduler completely. Original issue's description: > Implement timers by posting delayed tasks > > This patch refactors TimerBase to post tasks delayed tasks and > deletes the now-obsolete timer heap and shared timer mechanism. > > ATTN Sheriffs: If there are weird layout test flakes all of a > sudden, this patch may be the cause since the interleaving of > timers with other posted tasks will change. > > Original patch by Alex Clarke <[email protected]>. > > BUG=463143,416362,480522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196308 [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463143,416362,480522 Review URL: https://codereview.chromium.org/1162903005 git-svn-id: svn://svn.chromium.org/blink/trunk@196317 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rakuco
force-pushed
the
master
branch
2 times, most recently
from
18b4fba to
5d8a63a
Compare
rakuco
force-pushed
the
master
branch
2 times, most recently
from
6912fde to
fa523fc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChromiumEFL relies on a WebCore::Image API being exposed
in order to populate some context menu items.
Namely WebCore::Image::fileNameExtension();
Although there is a WebImage public class/API
that in theory could be extended, WebImage is not
about images stored in a file format, but mainly
about the pixel data of an image (for instance,
WebImage wraps a SkBitmap).
Because of this, it is preferable to extend WebElement accordingly.
A special note about the file name: Technically, "Filename"
should be camel cased, but I left it as-is to match the
existing Image counterpart API.
BUG=https://crosswalk-project.org/jira/browse/XWALK-2547