Added Support for Civo Object Store #54
Conversation
| return managed.ExternalObservation{ResourceExists: true}, err | ||
| } | ||
| } | ||
| _, err = e.Update(ctx, mg) |
There was a problem hiding this comment.
we should only update if the value of secret's don't match the access key id , etc we got from civo api.
| return err | ||
| } | ||
| objectStore, err := e.civoClient.GetObjectStoreByName(os.Spec.Name) | ||
| if err != nil { |
There was a problem hiding this comment.
this function is not idempotent. If the resource does not exist, we should consider it deleted.
| // +kubebuilder:resource:shortName="cos" | ||
| // +kubebuilder:printcolumn:name="State",type="string",JSONPath=".status.atProvider.status",description="State of the Bucket" | ||
| // +kubebuilder:printcolumn:name="Bucket",type="string",JSONPath=".spec.name",description="Name of the Bucket which can be used against S3 API" | ||
| // +kubebuilder:printcolumn:name="Size",type="string",JSONPath=".spec.maxSize",description="Size of the Bucket in GB" |
There was a problem hiding this comment.
I think it might be better to have used capacity here rather than requested.
There was a problem hiding this comment.
Again how should we get the used capacity?
There was a problem hiding this comment.
There's an endpoint at /v2/objectstore/id/stats.
There was a problem hiding this comment.
Can you check if we can display a percentage here? Would be nice to show utilised percentage.
Basically, .status.usedCapacity/.status.maxSize*100
There was a problem hiding this comment.
If not, rather than displaying usedCapacity, let's have utilisedPercentage in status and drop usedCapacity
| UsedCapacity string `json:"usedCapacity"` | ||
|
|
||
| // Status of the Object Store. | ||
| Status CivoObjectStoreStatus `json:"status,omitempty"` |
| Status CivoObjectStoreStatus `json:"status,omitempty"` | ||
|
|
||
| // Region where the Object Store is located | ||
| Region string `json:"region,omitempty"` |
There was a problem hiding this comment.
do we really need this? Isn't it implicit since they've the provider configured to single region?
…r K8s deps. Also…"" This reverts commit 3a288e1.
uzaxirr
force-pushed
the
objectstore-support
branch
from
9c00fea to
1af7164
Compare
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested