Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle offline mode in Flagship app #2186

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: Handle offline mode in Flagship app #2186

wants to merge 10 commits into from

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Sep 19, 2024 •
edited
Loading

We want cozy-home to be compatible with the new Flagship app's Offline mode

When hosted in a Flagship app's WebView we now want to use FlagshipLink instead of StackLink in cozy-client

This link will allow to redirect all queries to the Flagship app that will handle data access when offline but also when online

Related PR: cozy/cozy-client#1507
Related PR: cozy/cozy-flagship-app#1239
Related PR: cozy/cozy-libs#2562
Related PR: cozy/cozy-libs#2581
Related PR: cozy/cozy-libs#2585

### ✨ Features

* Add support for Offline mode in Flagship app

### 🐛 Bug Fixes

*

### 🔧 Tech

*

TODO:

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 19, 2024 •
edited
Loading

BundleMon

Files updated (7)
Status Path Size Limits
✅ vendors/home.(hash).js
 1.5MB (+3.6KB +0.24%) 1.6MB
✅ services/deleteAccounts/home.js
 311.05KB (+1.25KB +0.4%) 500KB
✅ services/myselfFromIdenties/home.js
 235.5KB (+1.15KB +0.49%) 245KB
✅ services/updateAccounts/home.js
 462.48KB (+1.02KB +0.22%) 467KB
✅ services/softDeleteOrRestoreAccounts/home.js
 465.35KB (+974B +0.2%) 490KB
✅ intents/home.(hash).js
 25.6KB (+91B +0.35%) 35KB
✅ app/home.(hash).js
 47.3KB (-118B -0.24%) 50KB
Unchanged files (6)
Status Path Size Limits
✅ services/polyfillFetch/home.js
 97.38KB 99KB
✅ vendors-home.(hash).(hash).min.css
 38.77KB 40KB
✅ services/attributesHelpers/home.js
 15.22KB 16KB
✅ app-home.(hash).min.css
 1.78KB 15KB
✅ intents/index.html
 650B 1KB
✅ intents-home.(hash).min.css
 158B 6KB

Total files change +7.94KB +0.25%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

Ldoppea added a commit to cozy/cozy-client that referenced this pull request Sep 19, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
54d8680 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: cozy/cozy-home#2186
@Ldoppea Ldoppea mentioned this pull request Sep 19, 2024
Merged
Ldoppea added a commit to cozy/cozy-client that referenced this pull request Sep 19, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
05641b0 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: cozy/cozy-home#2186
Ldoppea added a commit to cozy/cozy-client that referenced this pull request Sep 19, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
cf2a800 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: cozy/cozy-home#2186
Ldoppea added a commit to cozy/cozy-client that referenced this pull request Sep 23, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
2fcf290 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: cozy/cozy-home#2186
Ldoppea added a commit to cozy/cozy-client that referenced this pull request Sep 23, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
ecb276d 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: cozy/cozy-home#2186
Ldoppea added a commit to cozy/cozy-client that referenced this pull request Sep 24, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
0bee9ae 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: cozy/cozy-home#2186
This was referenced Sep 24, 2024
Merged
Open
Ldoppea added a commit to cozy/cozy-client that referenced this pull request Sep 24, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
6f23dbe 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: cozy/cozy-home#2186
Ldoppea added a commit to cozy/cozy-client that referenced this pull request Sep 24, 2024
@Ldoppea
feat: Handle queries that fetch Konnectors by channel
374782f 
`fetchJSON()` calls are not compatible with offline mode unless we wrap
them in the `.query()` dsl

Recently we added a `fetchJSON()` call inside of cozy-home in order to
display the new grouped-by-category folders in the home's konnectors
section

So we want to move this call inside of the AppsRegistryCollection in
order to make it compatible with offline mode

Related PR: cozy/cozy-home#2186
@Ldoppea
refactor: Use useSettings hook in DefaultRedirectionSnackbar
cafd347 
In cozy/cozy-client#1460 we implemented a new `useSettings` hook

This hook can be used in `DefaultRedirectionSnackbar` in order to
simplify code and homogenize the way we access cozy-apps settings
@Ldoppea
refactor: Rename helper to useShouldShowDefaultRedirectionSnackbar
fa234a1
@Ldoppea
feat: Upgrade cozy-harvest-lib
7f5be5b 
`cozy-harvest-lib` has been upgraded to `30.0.1` in order to retrieve a
fix on accounts fetching that provide support for Offline mode

Related PR: cozy/cozy-libs#2585
@Ldoppea
feat: Upgrade cozy-client and cozy-intent
1c0d809 
`cozy-client` has been upgraded to `49.0.0` in order to retrieve the
Offline mode support

`cozy-intent` has been upgraded to `2.23.0` as it is the new minimal
version for `cozy-client` since `49.0.0`

Related PR: cozy/cozy-client#1507
@Ldoppea
feat: Upgrade cozy-device-helper
8d428e7 
`cozy-device-helper` has been upgraded to `3.1.0` in order to retrieve
the Offline mode support

Related PR: cozy/cozy-libs#2562
@Ldoppea
feat: Handle offline mode in Flagship app
189dc77 
We want cozy-home to be compatible with the new Flagship app's Offline
mode

When hosted in a Flagship app's WebView we now want to use FlagshipLink
instead of StackLink in cozy-client

This link will allow to redirect all queries to the Flagship app that
will handle data access when offline but also when online

Related PR: cozy/cozy-client#1507
Related PR: cozy/cozy-flagship-app#1239
@Ldoppea
fix: Do not rely on .attributes from queries result
d4a2575
@Ldoppea
fix: Use a query for fetchAllKonnectors()
95cc6d3
@Ldoppea
feat: Declare offline compatibility in manifest.webapp
e56ea58
@Ldoppea
feat: Rename FlagshipLink to WebFlagshipLink
797a312 
Related PR: cozy/cozy-client#1536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acezard acezard Awaiting requested review from acezard

@doubleface doubleface Awaiting requested review from doubleface doubleface is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ldoppea