fix(mobile): Scroll after logout #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosssi
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that after logout on the mobile app, we couldn't scroll anymore. This was caused by the fact that when we open the cozy-bar, it sets an
overflow: hidden(and other stuff to prevent scroll) on thebody. But on logout, we simply destroy the cozy-bar DOM node. So we still had theoverflow: hiddenon thebody. Now I just erase all styles applied onbodyon logout, but we may think of a better API likedestroyorunmountdirectly in the cozy-bar to handle this correctly.