Add error handling in BeginBlock for IBC client #7938
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avorylli
commented
Feb 9, 2025
avorylli
commented
- Add proper error handling for BeginBlocker in core module
- Wrap error with context for better debugging
- Improve reliability by not silently ignoring potential errors
avorylli
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
gjermundgaraba
requested changes
Feb 18, 2025
| @@ -197,7 +197,9 @@ func (AppModule) ConsensusVersion() uint64 { return 7 } | |||
|
|
|||
| // BeginBlock returns the begin blocker for the ibc module. | |||
| func (am AppModule) BeginBlock(ctx context.Context) error { | |||
| ibcclient.BeginBlocker(sdk.UnwrapSDKContext(ctx), am.keeper.ClientKeeper) | |||
| if err := ibcclient.BeginBlocker(sdk.UnwrapSDKContext(ctx), am.keeper.ClientKeeper); err != nil { | |||
There was a problem hiding this comment.
It's OK to catch the error and log it, but we cannot return an error here as it would not let the block finalize and subsequently halt the chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.