feat: remove x/authz dependency from precompiles #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudgray
changed the title
cloudgray
changed the title
dongsam
reviewed
Apr 11, 2025
| @@ -60,15 +60,14 @@ func NewAvailableStaticPrecompiles( | |||
| panic(fmt.Errorf("failed to instantiate bech32 precompile: %w", err)) | |||
| } | |||
|
|
|||
| stakingPrecompile, err := stakingprecompile.NewPrecompile(stakingKeeper, authzKeeper) | |||
| stakingPrecompile, err := stakingprecompile.NewPrecompile(stakingKeeper) | |||
There was a problem hiding this comment.
In the arguments of NewAvailableStaticPrecompiles, it also seems possible to remove authzKeeper.
Additionally, I noticed that dependencies on Erc20Keeper, werc20 and erc20 precompiles (which are planned to be removed later as they will have their own state) still remain, so I’m leaving a note just in case it was overlooked.
FYI: temporary removed for IBC v2 test on this commit
There was a problem hiding this comment.
Thank you for feedback.
- In case of
NewAvailableStaticPrecompiles, I missed it, I'll fix it. - In case of erc20 and werc20, I intended that the task order that 1) add allowance state in x/erc20 module, 2) modify erc20 precompile, 3) modify werc20 precompile.
- And I will consider commit.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removal of x/authz dependency on precompiles
Approve,Revoke,IncreaseAllowance,DecreaseAllowance,Allowance) and its usage.Allowancestate CRUD methods in x/erc20 moduleAllowancestate of x/erc20 module instead ofGrantstate of x/authz module for authorization methods (Approve,Revoke,IncreaseAllowance,DecreaseAllowance,Allowance)Closes: #47
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md